Bug 125296

Summary:

[EFL] Buildfix after r160151

Product:

WebKit

Reporter:

Krzysztof Czech <k.czech>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, eflews.bot, gustavo, gyuyoung.kim, lucas.de.marchi, lvidacs.u-szeged, menard, mrobinson, nick.diego, ossy, pnormand, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	eflews.bot: commit-queue-
patch	none

Krzysztof Czech

Reported 2013-12-05 02:52:32 PST

/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:517: error: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Werror=format]

Attachments
patch (1.38 KB, patch) 2013-12-05 02:55 PST, Krzysztof Czech	eflews.bot: commit-queue-	Details Formatted Diff Diff
patch (1.40 KB, patch) 2013-12-05 04:57 PST, Krzysztof Czech	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Krzysztof Czech

Comment 1 2013-12-05 02:55:59 PST

Created attachment 218496 [details] patch

WebKit Commit Bot

Comment 2 2013-12-05 02:58:10 PST

Attachment 218496 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Krzysztof Czech

Comment 3 2013-12-05 03:03:59 PST

Changing format specifier from %ld to %d

EFL EWS Bot

Comment 4 2013-12-05 03:11:24 PST

Comment on attachment 218496 [details] patch Attachment 218496 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/39298350

EFL EWS Bot

Comment 5 2013-12-05 03:48:23 PST

Comment on attachment 218496 [details] patch Attachment 218496 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/43618008

Nick Diego Yamane (diegoyam)

Comment 6 2013-12-05 04:25:03 PST

/mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] Looks like it should be %lu :)

Ryuan Choi

Comment 7 2013-12-05 04:34:36 PST

(In reply to comment #6) > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > Looks like it should be %lu :) So, is static_cast<unsigned long>(length) only the solution ?

Krzysztof Czech

Comment 8 2013-12-05 04:53:46 PST

(In reply to comment #7) > (In reply to comment #6) > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > > > Looks like it should be %lu :) > > So, is static_cast<unsigned long>(length) only the solution ? What about signed values ?, maybe static_cast<long>(length)

Krzysztof Czech

Comment 9 2013-12-05 04:57:34 PST

Created attachment 218502 [details] patch

WebKit Commit Bot

Comment 10 2013-12-05 04:58:45 PST

Attachment 218502 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 11 2013-12-05 05:23:15 PST

*** Bug 125298 has been marked as a duplicate of this bug. ***

Laszlo Vidacs

Comment 12 2013-12-05 05:40:45 PST

A possible solution is submitted to https://bugs.webkit.org/show_bug.cgi?id=125298 Unsigned int does not fit in long int, so the common type for both values could be long long int. Could you take a look at that patch?

Csaba Osztrogonác

Comment 13 2013-12-05 14:42:02 PST

Mark this one as duplicate, because the other bug contains the proper fix. *** This bug has been marked as a duplicate of bug 125298 ***

Note You need to log in before you can comment on or make changes to this bug.