| Summary: | [EFL] Buildfix after r160151 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Krzysztof Czech <k.czech> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED DUPLICATE | ||||||||
| Severity: | Normal | CC: | commit-queue, eflews.bot, gustavo, gyuyoung.kim, lucas.de.marchi, lvidacs.u-szeged, menard, mrobinson, nick.diego, ossy, pnormand, ryuan.choi | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Krzysztof Czech
2013-12-05 02:52:32 PST
Created attachment 218496 [details]
patch
Attachment 218496 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Changing format specifier from %ld to %d Comment on attachment 218496 [details] patch Attachment 218496 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/39298350 Comment on attachment 218496 [details] patch Attachment 218496 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/43618008 /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] Looks like it should be %lu :) (In reply to comment #6) > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > Looks like it should be %lu :) So, is static_cast<unsigned long>(length) only the solution ? (In reply to comment #7) > (In reply to comment #6) > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > > > Looks like it should be %lu :) > > So, is static_cast<unsigned long>(length) only the solution ? What about signed values ?, maybe static_cast<long>(length) Created attachment 218502 [details]
patch
Attachment 218502 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 125298 has been marked as a duplicate of this bug. *** A possible solution is submitted to https://bugs.webkit.org/show_bug.cgi?id=125298 Unsigned int does not fit in long int, so the common type for both values could be long long int. Could you take a look at that patch? Mark this one as duplicate, because the other bug contains the proper fix. *** This bug has been marked as a duplicate of bug 125298 *** |