| Summary: | Style checker for .messages.in files (WTF:: prefix) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tamas Gergely <tgergely.u-szeged> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, commit-queue, galpeter, glenn, ossy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 124578 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Tamas Gergely
2013-12-03 02:11:15 PST
Created attachment 218281 [details]
patch adds .messages.in style checker.
Comment on attachment 218281 [details] patch adds .messages.in style checker. Rejecting attachment 218281 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 218281, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/42138184 Created attachment 218402 [details]
patch adds .messages.in style checker.
Fixed reviewer line in ChangeLog.
Comment on attachment 218402 [details] patch adds .messages.in style checker. Rejecting attachment 218402 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218402, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patch at line 36: patching file Tools/Scripts/webkitpy/style/checker.py Hunk #1 FAILED at 43. Hunk #2 succeeded at 635 (offset 6 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/style/checker.py.rej patching file Tools/Scripts/webkitpy/style/checkers/messagesin.py patching file Tools/Scripts/webkitpy/style/checkers/messagesin_unittest.py Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/43188023 Created attachment 218408 [details]
Updated patch.
Comment on attachment 218408 [details] Updated patch. Clearing flags on attachment: 218408 Committed r160093: <http://trac.webkit.org/changeset/160093> All reviewed patches have been landed. Closing bug. |