Bug 125007

Summary:

[EFL] Fix incorrectly position of the viewport

Product:

WebKit

Reporter:

Hunseop Jeong <hs85.jeong>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED INVALID

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, gyuyoung.kim, lucas.de.marchi, luiz, noam, rakuco, ryuan.choi, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Bug Depends on:

Bug Blocks:

124965

Attachments:

Description	Flags
Patch	ryuan.choi: commit-queue-

Hunseop Jeong

Reported 2013-11-29 03:58:47 PST

This bugs occurred by https://bugs.webkit.org/show_bug.cgi?id=124965. Added the missed part of previous patch.

Attachments
Patch (4.36 KB, patch) 2013-11-29 04:35 PST, Hunseop Jeong	ryuan.choi: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hunseop Jeong

Comment 1 2013-11-29 04:00:43 PST

Changed the titile name.

Hunseop Jeong

Comment 2 2013-11-29 04:01:25 PST

(In reply to comment #1) > Changed the titile name. titile -> title...

Hunseop Jeong

Comment 3 2013-11-29 04:35:22 PST

Created attachment 218052 [details] Patch

Ryuan Choi

Comment 4 2013-11-30 17:20:18 PST

Comment on attachment 218052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Fix incorrectly position of the viewport I think that title is really ambiguous. > Source/WebKit2/ChangeLog:8 > + The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965. What is wrong? The previous commit is also to fix wrong viewport issue. We need more information whether to decide to revert previous one or fix new regression.

Hunseop Jeong

Comment 5 2013-11-30 19:34:22 PST

(In reply to comment #4) > (From update of attachment 218052 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] Fix incorrectly position of the viewport > > I think that title is really ambiguous. > > > Source/WebKit2/ChangeLog:8 > > + The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965. > > What is wrong? The previous commit is also to fix wrong viewport issue. > > We need more information whether to decide to revert previous one or fix new regression. It Would be better to revert the previous patch.

Ryuan Choi

Comment 6 2013-11-30 19:59:51 PST

I reverted r159865 so that this is not needed. You can upload a patch at Bug 124965 when you find a better solution not to make regression (that the position of events are wrong)

Gyuyoung Kim

Comment 7 2013-12-25 18:57:15 PST

Comment on attachment 218052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review >>> Source/WebKit2/ChangeLog:3 >>> + [EFL] Fix incorrectly position of the viewport >> >> I think that title is really ambiguous. > > It Would be better to revert the previous patch. incorrectly -> incorrect. And also, this patch touch coordinated graphics. So, it would be good to add [CoordinatedGraphics] as well. > Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:248 > +AffineTransform WebView::transformToUserViewport() const Could you explain why you use *UserViewport* in function name ?

Gyuyoung Kim

Comment 8 2013-12-25 18:57:51 PST

Comment on attachment 218052 [details] Patch Oops. This patch was already closed. Clear r?.

Hunseop Jeong

Comment 9 2013-12-25 19:05:34 PST

Oops,,! I missed closing the issue. Sorry!

Note You need to log in before you can comment on or make changes to this bug.