Bug 124958

Summary:

Remove BreakingContext's friendship from RenderBlockFlow

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

121261

Attachments:

Description	Flags
Patch	hyatt: review+, commit-queue: commit-queue-
patch for landing	none

Zoltan Horvath

Reported 2013-11-27 20:42:34 PST

BreakingContext uses only 2 functions from RenderBlockFlow: insertFloatingObject/positionNewFloatOnLine. I added helper functions for LineBreaker, what is already a friend of RenderBlockFlow, so BreakingContext doesn't need to be anymore.

Attachments
Patch (3.83 KB, patch) 2013-11-27 20:45 PST, Zoltan Horvath	hyatt: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch for landing (3.82 KB, patch) 2013-12-03 23:04 PST, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2013-11-27 20:45:32 PST

Created attachment 217978 [details] Patch

Dave Hyatt

Comment 2 2013-12-03 14:21:16 PST

Comment on attachment 217978 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-12-03 14:33:42 PST

Comment on attachment 217978 [details] Patch Rejecting attachment 217978 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 217978, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderBlockFlow.h patching file Source/WebCore/rendering/line/BreakingContextInlineHeaders.h Hunk #1 FAILED at 456. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/line/BreakingContextInlineHeaders.h.rej patching file Source/WebCore/rendering/line/LineBreaker.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42958036

Zoltan Horvath

Comment 4 2013-12-03 23:04:17 PST

Created attachment 218384 [details] patch for landing

WebKit Commit Bot

Comment 5 2013-12-03 23:53:37 PST

Comment on attachment 218384 [details] patch for landing Clearing flags on attachment: 218384 Committed r160073: <http://trac.webkit.org/changeset/160073>

WebKit Commit Bot

Comment 6 2013-12-03 23:53:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.