Bug 124903

Summary:

[CSS Shapes] Support inset parsing

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, rego+ews, syoichi, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

124905, 124906

Bug Blocks:

124173, 125112

Attachments:

Description	Flags
patch - style won't make it	eflews.bot: commit-queue-
patch - style won't make it	hyatt: review+, commit-queue: commit-queue-
updated patch for landing	commit-queue: commit-queue-
updated patch 2 for landing	none

Zoltan Horvath

Reported 2013-11-26 15:41:27 PST

Shapes level 1 defines inset shape, this patch adds support for inset parsing.

Attachments
patch - style won't make it (55.26 KB, patch) 2013-11-26 17:48 PST, Zoltan Horvath	eflews.bot: commit-queue-	Details Formatted Diff Diff
patch - style won't make it (58.63 KB, patch) 2013-11-26 20:58 PST, Zoltan Horvath	hyatt: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
updated patch for landing (58.42 KB, patch) 2013-12-02 13:14 PST, Zoltan Horvath	commit-queue: commit-queue-	Details Formatted Diff Diff
updated patch 2 for landing (58.63 KB, patch) 2013-12-02 13:50 PST, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2013-11-26 17:48:07 PST

Created attachment 217915 [details] patch - style won't make it

WebKit Commit Bot

Comment 2 2013-11-26 17:50:22 PST

Attachment 217915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths.html', u'LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-test-utils.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSBasicShapes.cpp', u'Source/WebCore/css/CSSBasicShapes.h', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSValuePool.h', u'Source/WebCore/platform/LengthSize.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h']" exit_code: 1 Source/WebCore/css/CSSParser.cpp:5444: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2013-11-26 18:20:19 PST

Comment on attachment 217915 [details] patch - style won't make it Attachment 217915 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/37678003

EFL EWS Bot

Comment 4 2013-11-26 18:34:15 PST

Comment on attachment 217915 [details] patch - style won't make it Attachment 217915 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/37658004

Zoltan Horvath

Comment 5 2013-11-26 20:58:12 PST

Created attachment 217923 [details] patch - style won't make it

WebKit Commit Bot

Comment 6 2013-11-26 20:59:06 PST

Attachment 217923 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths.html', u'LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-test-utils.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSBasicShapes.cpp', u'Source/WebCore/css/CSSBasicShapes.h', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSValuePool.h', u'Source/WebCore/platform/LengthSize.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h']" exit_code: 1 Source/WebCore/css/CSSParser.cpp:5444: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 7 2013-12-02 09:10:50 PST

Comment on attachment 217923 [details] patch - style won't make it r=me

WebKit Commit Bot

Comment 8 2013-12-02 09:16:23 PST

Comment on attachment 217923 [details] patch - style won't make it Rejecting attachment 217923 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: et -10 lines). Hunk #4 succeeded at 368 (offset -10 lines). patching file Source/WebCore/css/CSSValuePool.h patching file Source/WebCore/platform/LengthSize.h patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp patching file Source/WebCore/rendering/style/BasicShapes.cpp patching file Source/WebCore/rendering/style/BasicShapes.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/40018077

WebKit Commit Bot

Comment 9 2013-12-02 09:19:30 PST

Comment on attachment 217923 [details] patch - style won't make it Rejecting attachment 217923 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: et -10 lines). Hunk #4 succeeded at 368 (offset -10 lines). patching file Source/WebCore/css/CSSValuePool.h patching file Source/WebCore/platform/LengthSize.h patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp patching file Source/WebCore/rendering/style/BasicShapes.cpp patching file Source/WebCore/rendering/style/BasicShapes.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42158016

WebKit Commit Bot

Comment 10 2013-12-02 10:36:29 PST

Comment on attachment 217923 [details] patch - style won't make it Rejecting attachment 217923 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: et -10 lines). Hunk #4 succeeded at 368 (offset -10 lines). patching file Source/WebCore/css/CSSValuePool.h patching file Source/WebCore/platform/LengthSize.h patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp patching file Source/WebCore/rendering/style/BasicShapes.cpp patching file Source/WebCore/rendering/style/BasicShapes.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42138037

Zoltan Horvath

Comment 11 2013-12-02 13:14:24 PST

Created attachment 218208 [details] updated patch for landing

WebKit Commit Bot

Comment 12 2013-12-02 13:16:28 PST

Comment on attachment 218208 [details] updated patch for landing Rejecting attachment 218208 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218208, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /WebCore/rendering/shapes/ShapeInsideInfo.cpp patching file Source/WebCore/rendering/style/BasicShapes.cpp Hunk #1 succeeded at 299 (offset 45 lines). patching file Source/WebCore/rendering/style/BasicShapes.h Hunk #2 FAILED at 52. Hunk #3 succeeded at 354 (offset 28 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/style/BasicShapes.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42278004

Zoltan Horvath

Comment 13 2013-12-02 13:50:42 PST

Created attachment 218211 [details] updated patch 2 for landing

WebKit Commit Bot

Comment 14 2013-12-02 14:46:11 PST

Comment on attachment 218211 [details] updated patch 2 for landing Clearing flags on attachment: 218211 Committed r159968: <http://trac.webkit.org/changeset/159968>

WebKit Commit Bot

Comment 15 2013-12-02 14:46:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.