Bug 124892

Summary: arm and sh4 paths could be merged in ThunkGenerators and privateCompileCTINativeCall
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, msaboff, oliver, ossy, rgabor, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Merge arm and sh4 paths in nativeForGenerator function.
none
Merge arm and sh4 paths in nativeForGenerator function (with style fix).
none
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. none

Description Julien Brianceau 2013-11-26 08:41:25 PST 
In nativeForGenerator function, CPU(ARM) and CPU(SH4) paths are the same and could be merged to reduce code duplication.
Comment 1 Julien Brianceau 2013-11-26 08:52:15 PST 
Created attachment 217880 [details]
Merge arm and sh4 paths in nativeForGenerator function.
Comment 2 WebKit Commit Bot 2013-11-26 08:53:28 PST 
Attachment 217880 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:356:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Julien Brianceau 2013-11-26 13:53:36 PST 
Created attachment 217899 [details]
Merge arm and sh4 paths in nativeForGenerator function (with style fix).

Same patch with style fix.
Comment 4 Julien Brianceau 2013-11-27 02:08:58 PST 
Created attachment 217929 [details]
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
Comment 5 Zoltan Herczeg 2013-11-29 05:47:43 PST 
Comment on attachment 217929 [details]
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.

r=me
Comment 6 WebKit Commit Bot 2013-11-29 06:13:38 PST 
Comment on attachment 217929 [details]
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.

Clearing flags on attachment: 217929

Committed r159871: <http://trac.webkit.org/changeset/159871>
Comment 7 WebKit Commit Bot 2013-11-29 06:13:40 PST 
All reviewed patches have been landed.  Closing bug.