Bug 124867

Summary: More prep work for GStreamer on Windows
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2013-11-25 15:14:58 PST
I have some compile fixes, and g_main_context_iteration needs to be called in the main loop for GStreamer to work.
Attachments
Patch (2.78 KB, patch)
2013-11-25 15:21 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2013-12-16 22:14 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-11-25 15:20:39 PST
The WinLauncher change is based on http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=commitdiff;h=895ab852892ec2e6393e41cc8576d4bbcfe636ea
Alex Christensen
Comment 2 2013-11-25 15:21:49 PST
Created attachment 217839 [details] Patch
Philippe Normand
Comment 3 2013-11-25 23:17:34 PST
Comment on attachment 217839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217839&action=review > Tools/WinLauncher/WinLauncher.cpp:45 > +#if USE(GSTREAMER) IIRC there is an ENABLE(GLIB_SUPPORT). Perhaps it would make more sense to enable that macro in WinCairo and use it here. > Tools/WinLauncher/WinLauncher.cpp:623 > +#if USE(GSTREAMER) Ditto
Alex Christensen
Comment 4 2013-12-16 22:11:41 PST
https://bugs.webkit.org/show_bug.cgi?id=104266 changed that to USE(GLIB), which would be a better fit there.
Alex Christensen
Comment 5 2013-12-16 22:14:42 PST
Created attachment 219398 [details] Patch
WebKit Commit Bot
Comment 6 2013-12-17 08:52:27 PST
Comment on attachment 219398 [details] Patch Clearing flags on attachment: 219398 Committed r160707: <http://trac.webkit.org/changeset/160707>
WebKit Commit Bot
Comment 7 2013-12-17 08:52:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.