Summary: | Implement asymmetric/symmetric stretching of vertical operators | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, cfleizach, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, mrobinson, rniwa | ||||||||||||||||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||
Bug Depends on: | 99620, 119043 | ||||||||||||||||||||||||
Bug Blocks: | 124838, 158866 | ||||||||||||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2013-11-25 01:22:36 PST
Created attachment 224731 [details] Patch Here is a very simple patch that applies on top of the one of bug 119043. Created attachment 224732 [details]
Patch + 119043 for testing
Comment on attachment 224732 [details] Patch + 119043 for testing Attachment 224732 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6603106544517120 New failing tests: mathml/presentation/mo-stretch.html Created attachment 224739 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224732 [details] Patch + 119043 for testing Attachment 224732 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4611460684578816 New failing tests: mathml/presentation/mo-stretch.html Created attachment 224740 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 224732 [details] Patch + 119043 for testing Attachment 224732 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5664742089687040 New failing tests: mathml/presentation/mo-stretch.html Created attachment 224741 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224732 [details] Patch + 119043 for testing Attachment 224732 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6206439739621376 New failing tests: mathml/presentation/mo-stretch.html Created attachment 224746 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 224850 [details]
Patch
Created attachment 224851 [details]
Patch + 119043 for testing
Comment on attachment 224851 [details] Patch + 119043 for testing Attachment 224851 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5191576280104960 New failing tests: mathml/presentation/mo-stretch.html Created attachment 224858 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 224859 [details] Patch Rebase mo-stretch to take into account the symmetric property. I'm asking review but the tests will fail because this depends on bug 119043. Comment on attachment 224859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224859&action=review > LayoutTests/mathml/presentation/stretchy-depth-height-symmetric.html:11 > + return Math.abs(x - y) < epsilon; indendation levels should be +4 spaces > Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1266 > + // FIXME: We should read the read the axis from the MATH table (https://bugs.webkit.org/show_bug.cgi?id=122297). For now, we use the same value as in RenderMathMLFraction::firstLineBaseline(). too many words ---"should read the read the" Committed r164537: <http://trac.webkit.org/changeset/164537> Mass change: add WebExposed keyword to help MDN documentation. |