Bug 124649

Summary:

[arm_traditional] Build fails since r159545

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, msaboff, ossy, rgabor, sam, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

108645

Attachments:

Description	Flags
Add missing implementations in ARM_TRADITIONAL macro assembler.	none

Description Julien Brianceau 2013-11-20 02:48:25 PST

The following implementations are missing in ARM_TRADITIONAL macro assembler since r159545:
- void memoryFence()
- void load8(const void*, RegisterID)
- void load8(const void*, RegisterID)

Comment 1 Julien Brianceau 2013-11-20 02:49:21 PST

- void store8(RegisterID, const void*)

Comment 2 Julien Brianceau 2013-11-20 02:54:07 PST

Created attachment 217412 [details]
Add missing implementations in ARM_TRADITIONAL macro assembler.

Comment 3 WebKit Commit Bot 2013-11-20 02:55:27 PST

Attachment 217412 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/ARMAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerARM.h']" exit_code: 1
Source/JavaScriptCore/assembler/ARMAssembler.h:233:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 WebKit Commit Bot 2013-11-20 10:30:14 PST

Comment on attachment 217412 [details]
Add missing implementations in ARM_TRADITIONAL macro assembler.

Clearing flags on attachment: 217412

Committed r159571: <http://trac.webkit.org/changeset/159571>

Comment 5 WebKit Commit Bot 2013-11-20 10:30:16 PST

All reviewed patches have been landed.  Closing bug.