Bug 124646

Summary: [armv7][arm64] Build is likely to fail since r159545
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ossy, rgabor, sam, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler.
none
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2).
none
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b. none

Description Julien Brianceau 2013-11-20 01:46:05 PST
Build is likely to fail since http://trac.webkit.org/changeset/159545 for ARMv7 and ARM64 architectures.

"memfence" should be renamed "memoryFence" in Macro Assembler.
Comment 1 Julien Brianceau 2013-11-20 01:50:53 PST
Created attachment 217407 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler.
Comment 2 Julien Brianceau 2013-11-20 01:52:21 PST
Created attachment 217408 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2).
Comment 3 Julien Brianceau 2013-11-20 02:37:50 PST
Created attachment 217411 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b.

I also think that one of the two "OP_DMB_SY_T2a" should be "OP_DMB_SY_T2b".
Comment 4 WebKit Commit Bot 2013-11-20 08:00:21 PST
Comment on attachment 217411 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b.

Clearing flags on attachment: 217411

Committed r159564: <http://trac.webkit.org/changeset/159564>
Comment 5 WebKit Commit Bot 2013-11-20 08:00:25 PST
All reviewed patches have been landed.  Closing bug.