Bug 124488

Summary: [arm] Build fails since r159395.
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, rgabor, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. none

Description Julien Brianceau 2013-11-18 02:18:07 PST
Build fails for CPU(ARM_TRADITIONAL) since http://trac.webkit.org/changeset/159395 because the following function is missing from MacroAssembler:

    Jump branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right)
Comment 1 Julien Brianceau 2013-11-18 02:19:40 PST
Created attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.
Comment 2 Zoltan Herczeg 2013-11-18 03:10:16 PST
Comment on attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.

Patch looks good.
Comment 3 WebKit Commit Bot 2013-11-18 03:35:03 PST
Comment on attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.

Clearing flags on attachment: 217183

Committed r159415: <http://trac.webkit.org/changeset/159415>
Comment 4 WebKit Commit Bot 2013-11-18 03:35:05 PST
All reviewed patches have been landed.  Closing bug.