Bug 124461

Summary:

Refactor static getter function prototype to include thisValue in addition to the base object

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, darin, eflews.bot, gtk-ews, gyuyoung.kim, rego+ews, rniwa, sam, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

125325

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Patch	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Patch	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Patch	ggaren: review+

Oliver Hunt

Reported 2013-11-16 13:48:55 PST

Refactor static getter function prototype to include thisValue in addition to the base object

Attachments
Patch (111.83 KB, patch) 2013-11-16 13:54 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (111.99 KB, patch) 2013-11-16 14:19 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (150.83 KB, application/zip) 2013-11-16 15:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (141.65 KB, application/zip) 2013-11-16 16:09 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (141.41 KB, application/zip) 2013-11-16 16:58 PST, Build Bot	no flags	Details
Patch (112.00 KB, patch) 2013-11-20 12:20 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (163.05 KB, application/zip) 2013-11-20 13:14 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (252.04 KB, application/zip) 2013-11-20 13:50 PST, Build Bot	no flags	Details
Patch (111.26 KB, patch) 2013-11-20 13:53 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (111.26 KB, patch) 2013-11-20 14:06 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (111.26 KB, patch) 2013-11-20 15:40 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (111.26 KB, patch) 2013-11-20 15:42 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (589.85 KB, application/zip) 2013-11-20 17:01 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (464.54 KB, application/zip) 2013-11-20 17:48 PST, Build Bot	no flags	Details
Patch (111.24 KB, patch) 2013-11-21 14:59 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (467.48 KB, application/zip) 2013-11-21 17:07 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (471.05 KB, application/zip) 2013-11-21 18:16 PST, Build Bot	no flags	Details
Patch (110.79 KB, patch) 2013-11-26 13:53 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (476.01 KB, application/zip) 2013-11-26 16:05 PST, Build Bot	no flags	Details
Patch (111.28 KB, patch) 2013-12-04 14:39 PST, Oliver Hunt	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2013-11-16 13:54:09 PST

Created attachment 217133 [details] Patch

kov's GTK+ EWS bot

Comment 2 2013-11-16 14:16:48 PST

Comment on attachment 217133 [details] Patch Attachment 217133 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/25308009

Oliver Hunt

Comment 3 2013-11-16 14:19:57 PST

Created attachment 217134 [details] Patch

Build Bot

Comment 4 2013-11-16 15:12:04 PST

Comment on attachment 217134 [details] Patch Attachment 217134 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/24398004 New failing tests: compositing/checkerboard.html compositing/geometry/abs-position-inside-opacity.html compositing/geometry/fixed-in-composited.html animations/additive-transform-animations.html compositing/framesets/composited-frame-alignment.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html compositing/geometry/layer-due-to-layer-children-deep.html compositing/iframes/iframe-in-composited-layer.html compositing/geometry/fixed-position.html canvas/philip/tests/2d.imageData.object.ctor.html compositing/animation/state-at-end-event-transform-layer.html canvas/philip/tests/2d.imageData.create1.type.html canvas/philip/tests/2d.imageData.get.type.html animations/3d/change-transform-in-end-event.html compositing/animation/busy-indicator.html animations/3d/matrix-transform-type-animation.html compositing/geometry/horizontal-scroll-composited.html compositing/iframes/iframe-copy-on-scroll.html compositing/iframes/iframe-content-flipping.html compositing/geometry/clipping-foreground.html compositing/iframes/composited-iframe-scroll.html animations/animation-css-rule-types.html compositing/geometry/composited-html-size.html compositing/compositing-visible-descendant.html compositing/iframes/composited-iframe-alignment.html compositing/color-matching/image-color-matching.html canvas/philip/tests/2d.imageData.create2.type.html canvas/philip/tests/2d.gradient.object.return.html compositing/color-matching/pdf-image-match.html

Build Bot

Comment 5 2013-11-16 15:12:08 PST

Created attachment 217136 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2013-11-16 16:09:14 PST

Comment on attachment 217134 [details] Patch Attachment 217134 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22048036 New failing tests: compositing/checkerboard.html canvas/philip/tests/type.prototype.html animations/3d/matrix-transform-type-animation.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html canvas/philip/tests/type.extend.html animations/additive-transform-animations.html http/tests/appcache/deferred-events-delete-while-raising-timer.html http/tests/appcache/crash-when-navigating-away-then-back.html canvas/philip/tests/2d.imageData.object.ctor.html canvas/philip/tests/2d.imageData.create1.type.html compositing/animation/state-at-end-event-transform-layer.html animations/change-keyframes.html compositing/background-color/background-color-alpha-with-opacity.html canvas/philip/tests/2d.imageData.get.type.html animations/3d/change-transform-in-end-event.html compositing/animation/busy-indicator.html compositing/backgrounds/fixed-background-on-descendant.html animations/change-keyframes-name.html canvas/philip/tests/type.exists.html animations/cross-fade-border-image-source.html canvas/philip/tests/2d.pattern.basic.type.html animations/animation-css-rule-types.html compositing/compositing-visible-descendant.html canvas/philip/tests/type.replace.html compositing/color-matching/image-color-matching.html canvas/philip/tests/2d.imageData.create2.type.html http/tests/appcache/404-manifest.html canvas/philip/tests/2d.gradient.object.return.html compositing/color-matching/pdf-image-match.html

Build Bot

Comment 7 2013-11-16 16:09:17 PST

Created attachment 217140 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2013-11-16 16:58:35 PST

Comment on attachment 217134 [details] Patch Attachment 217134 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/25348033 New failing tests: compositing/checkerboard.html canvas/philip/tests/type.prototype.html animations/3d/matrix-transform-type-animation.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html canvas/philip/tests/type.extend.html animations/additive-transform-animations.html http/tests/appcache/deferred-events-delete-while-raising-timer.html http/tests/appcache/crash-when-navigating-away-then-back.html canvas/philip/tests/2d.imageData.object.ctor.html canvas/philip/tests/2d.imageData.create1.type.html compositing/animation/state-at-end-event-transform-layer.html animations/change-keyframes.html compositing/background-color/background-color-alpha-with-opacity.html canvas/philip/tests/2d.imageData.get.type.html animations/3d/change-transform-in-end-event.html compositing/animation/busy-indicator.html compositing/backgrounds/fixed-background-on-descendant.html animations/change-keyframes-name.html canvas/philip/tests/type.exists.html animations/cross-fade-border-image-source.html canvas/philip/tests/2d.pattern.basic.type.html animations/animation-css-rule-types.html compositing/compositing-visible-descendant.html canvas/philip/tests/type.replace.html compositing/color-matching/image-color-matching.html canvas/philip/tests/2d.imageData.create2.type.html http/tests/appcache/404-manifest.html canvas/philip/tests/2d.gradient.object.return.html compositing/color-matching/pdf-image-match.html

Build Bot

Comment 9 2013-11-16 16:58:37 PST

Created attachment 217142 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Sam Weinig

Comment 10 2013-11-17 12:07:04 PST

What will the this object be used for? What is this in anticipation for?

Oliver Hunt

Comment 11 2013-11-20 12:20:50 PST

Created attachment 217464 [details] Patch

Build Bot

Comment 12 2013-11-20 13:14:53 PST

Comment on attachment 217464 [details] Patch Attachment 217464 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/29938031 New failing tests: compositing/checkerboard.html compositing/geometry/abs-position-inside-opacity.html compositing/geometry/fixed-in-composited.html compositing/geometry/layer-due-to-layer-children.html animations/3d/matrix-transform-type-animation.html compositing/framesets/composited-frame-alignment.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html compositing/geometry/layer-due-to-layer-children-deep.html animations/additive-transform-animations.html compositing/geometry/fixed-position.html canvas/philip/tests/2d.imageData.object.ctor.html compositing/animation/state-at-end-event-transform-layer.html canvas/philip/tests/2d.imageData.create1.type.html canvas/philip/tests/2d.imageData.get.type.html animations/3d/change-transform-in-end-event.html compositing/animation/busy-indicator.html compositing/geometry/horizontal-scroll-composited.html compositing/geometry/limit-layer-bounds-overflow-repaint.html compositing/geometry/clipping-foreground.html compositing/iframes/composited-iframe-scroll.html animations/animation-css-rule-types.html compositing/geometry/composited-html-size.html compositing/compositing-visible-descendant.html compositing/iframes/composited-iframe-alignment.html compositing/color-matching/image-color-matching.html canvas/philip/tests/2d.imageData.create2.type.html canvas/philip/tests/2d.gradient.object.return.html compositing/color-matching/pdf-image-match.html compositing/geometry/outline-change.html

Build Bot

Comment 13 2013-11-20 13:14:56 PST

Created attachment 217470 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 14 2013-11-20 13:50:57 PST

Comment on attachment 217464 [details] Patch Attachment 217464 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/30968001 New failing tests: compositing/checkerboard.html canvas/philip/tests/type.prototype.html animations/3d/matrix-transform-type-animation.html compositing/framesets/composited-frame-alignment.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html canvas/philip/tests/type.extend.html animations/additive-transform-animations.html http/tests/appcache/deferred-events-delete-while-raising-timer.html http/tests/appcache/crash-when-navigating-away-then-back.html canvas/philip/tests/2d.imageData.object.ctor.html canvas/philip/tests/2d.imageData.create1.type.html compositing/animation/state-at-end-event-transform-layer.html animations/change-keyframes.html compositing/background-color/background-color-alpha-with-opacity.html canvas/philip/tests/2d.imageData.get.type.html animations/3d/change-transform-in-end-event.html compositing/animation/busy-indicator.html compositing/backgrounds/fixed-background-on-descendant.html animations/change-keyframes-name.html canvas/philip/tests/type.exists.html canvas/philip/tests/2d.pattern.basic.type.html animations/animation-css-rule-types.html compositing/compositing-visible-descendant.html canvas/philip/tests/type.replace.html compositing/color-matching/image-color-matching.html canvas/philip/tests/2d.imageData.create2.type.html http/tests/appcache/404-manifest.html canvas/philip/tests/2d.gradient.object.return.html compositing/color-matching/pdf-image-match.html

Build Bot

Comment 15 2013-11-20 13:50:59 PST

Created attachment 217475 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Oliver Hunt

Comment 16 2013-11-20 13:53:59 PST

Created attachment 217477 [details] Patch

EFL EWS Bot

Comment 17 2013-11-20 14:05:24 PST

Comment on attachment 217477 [details] Patch Attachment 217477 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/30688015

Oliver Hunt

Comment 18 2013-11-20 14:06:10 PST

Created attachment 217478 [details] Patch

EFL EWS Bot

Comment 19 2013-11-20 14:14:55 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/30148027

EFL EWS Bot

Comment 20 2013-11-20 14:27:18 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/30728018

kov's GTK+ EWS bot

Comment 21 2013-11-20 14:40:16 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/30698018

Build Bot

Comment 22 2013-11-20 14:41:46 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/30048068

Build Bot

Comment 23 2013-11-20 14:45:42 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/30048071

Build Bot

Comment 24 2013-11-20 15:03:46 PST

Comment on attachment 217478 [details] Patch Attachment 217478 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/30718021

Oliver Hunt

Comment 25 2013-11-20 15:40:36 PST

Created attachment 217487 [details] Patch

Oliver Hunt

Comment 26 2013-11-20 15:42:55 PST

Created attachment 217488 [details] Patch

Build Bot

Comment 27 2013-11-20 17:01:11 PST

Comment on attachment 217488 [details] Patch Attachment 217488 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/31598005 New failing tests: js/dom/toString-and-valueOf-override.html

Build Bot

Comment 28 2013-11-20 17:01:14 PST

Created attachment 217496 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 29 2013-11-20 17:48:49 PST

Comment on attachment 217488 [details] Patch Attachment 217488 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/31748023 New failing tests: js/dom/toString-and-valueOf-override.html

Build Bot

Comment 30 2013-11-20 17:48:53 PST

Created attachment 217508 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Sam Weinig

Comment 31 2013-11-20 20:10:21 PST

What will the this object be used for? What is this in anticipation for?

Oliver Hunt

Comment 32 2013-11-21 14:59:29 PST

Created attachment 217618 [details] Patch

Build Bot

Comment 33 2013-11-21 17:07:09 PST

Comment on attachment 217618 [details] Patch Attachment 217618 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/33388002 New failing tests: js/dom/toString-and-valueOf-override.html

Build Bot

Comment 34 2013-11-21 17:07:12 PST

Created attachment 217631 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 35 2013-11-21 18:16:42 PST

Comment on attachment 217618 [details] Patch Attachment 217618 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/33098025 New failing tests: js/dom/toString-and-valueOf-override.html

Build Bot

Comment 36 2013-11-21 18:16:48 PST

Created attachment 217639 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Oliver Hunt

Comment 37 2013-11-26 13:53:29 PST

Created attachment 217898 [details] Patch

Build Bot

Comment 38 2013-11-26 16:05:49 PST

Comment on attachment 217898 [details] Patch Attachment 217898 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/37488029 New failing tests: js/dom/toString-and-valueOf-override.html

Build Bot

Comment 39 2013-11-26 16:05:53 PST

Created attachment 217908 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Oliver Hunt

Comment 40 2013-12-04 14:39:55 PST

Created attachment 218451 [details] Patch

Geoffrey Garen

Comment 41 2013-12-04 15:08:26 PST

Comment on attachment 218451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218451&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + that this patch does not result in any change in behaviour Period, please. You should also mention the future changes you're planning: moving DOM properties to prototypes.

Oliver Hunt

Comment 42 2013-12-04 15:17:58 PST

Committed r160133: <http://trac.webkit.org/changeset/160133>

Darin Adler

Comment 43 2013-12-04 21:40:26 PST

Need to update bindings test expected results.

WebKit Commit Bot

Comment 44 2013-12-05 17:12:11 PST

Re-opened since this is blocked by bug 125325

Oliver Hunt

Comment 45 2013-12-05 19:00:37 PST

Committed r160208: <http://trac.webkit.org/changeset/160208>

Note You need to log in before you can comment on or make changes to this bug.