Bug 124336

Summary:

Move BreakingContext and LineBreaker into their own files

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebKit Misc.

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kondapallykalyan, rakuco, rniwa, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

121261

Attachments:

Description	Flags
EWS bullet - style won't make it (expected)	gtk-ews: commit-queue-
EWS bullet2 - style won't make it (expected)	buildbot: commit-queue-
EWS bullet3 - style won't make it (expected)	buildbot: commit-queue-
EWS bullet4 - style won't make it (expected)	none
EWS bullet5 for windows - style won't make it (expected)	none

Zoltan Horvath

Reported 2013-11-14 00:43:56 PST

Move out classes from RenderBlockLineLayout.cpp into their own files.

Attachments
EWS bullet - style won't make it (expected) (169.20 KB, patch) 2013-11-14 00:57 PST, Zoltan Horvath	gtk-ews: commit-queue-	Details Formatted Diff Diff
EWS bullet2 - style won't make it (expected) (169.74 KB, patch) 2013-11-14 01:11 PST, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
EWS bullet3 - style won't make it (expected) (170.78 KB, patch) 2013-11-14 10:42 PST, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
EWS bullet4 - style won't make it (expected) (177.28 KB, patch) 2013-11-14 14:15 PST, Zoltan Horvath	no flags	Details Formatted Diff Diff
EWS bullet5 for windows - style won't make it (expected) (177.28 KB, patch) 2013-11-14 16:46 PST, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2013-11-14 00:57:16 PST

Created attachment 216904 [details] EWS bullet - style won't make it (expected)

WebKit Commit Bot

Comment 2 2013-11-14 00:59:56 PST

Attachment 216904 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

kov's GTK+ EWS bot

Comment 3 2013-11-14 01:04:29 PST

Comment on attachment 216904 [details] EWS bullet - style won't make it (expected) Attachment 216904 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22700308

Zoltan Horvath

Comment 4 2013-11-14 01:11:49 PST

Created attachment 216906 [details] EWS bullet2 - style won't make it (expected)

WebKit Commit Bot

Comment 5 2013-11-14 01:13:58 PST

Attachment 216906 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2013-11-14 01:44:38 PST

Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22590168

Build Bot

Comment 7 2013-11-14 01:52:14 PST

Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/22889255

Build Bot

Comment 8 2013-11-14 02:22:45 PST

Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22838003

Build Bot

Comment 9 2013-11-14 02:23:36 PST

Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22720140

Zoltan Horvath

Comment 10 2013-11-14 10:42:54 PST

Created attachment 216959 [details] EWS bullet3 - style won't make it (expected)

WebKit Commit Bot

Comment 11 2013-11-14 10:44:33 PST

Attachment 216959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 12 2013-11-14 11:28:08 PST

Comment on attachment 216959 [details] EWS bullet3 - style won't make it (expected) Attachment 216959 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/23638034

Brent Fulgham

Comment 13 2013-11-14 14:10:22 PST

Comment on attachment 216959 [details] EWS bullet3 - style won't make it (expected) Because we now need access to headers in the "rendering/line" directory, we need to update the WebCoreCommon.props file's <AdditionalIncludeDirectories> stanza. Look for "mathml" on that line, and make a similar entry for the new "lines" section. It's possible you will need to update the "WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd" to also copy the header files from "lines", but I think these are not exposed outside of WebCore, so just changing the include path (above) is all that's necessary.

Zoltan Horvath

Comment 14 2013-11-14 14:15:07 PST

Created attachment 216979 [details] EWS bullet4 - style won't make it (expected)

WebKit Commit Bot

Comment 15 2013-11-14 14:16:40 PST

Attachment 216979 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zoltan Horvath

Comment 16 2013-11-14 16:46:14 PST

Created attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected)

WebKit Commit Bot

Comment 17 2013-11-14 16:48:50 PST

Attachment 216999 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 18 2013-11-15 09:31:46 PST

Comment on attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected) r=me

WebKit Commit Bot

Comment 19 2013-11-15 13:38:46 PST

Comment on attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected) Clearing flags on attachment: 216999 Committed r159354: <http://trac.webkit.org/changeset/159354>

WebKit Commit Bot

Comment 20 2013-11-15 13:38:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.