Bug 12412

Summary: "unimplemented propertyID: 46" seen at dojotoolkit.org
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: dev+webkit
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://dojotoolkit.org/
Bug Depends on:    
Bug Blocks: 13846    
Attachments:
Description Flags
patch, including layout test updates bdakin: review+

Darin Adler
Reported 2007-01-26 03:12:47 PST
As seen in bug 11673, this error message appears when trying to browse at dojotoolkit.org
Attachments
patch, including layout test updates (49.38 KB, patch)
2007-01-26 03:36 PST, Darin Adler 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-01-26 03:36:33 PST
Created attachment 12678 [details] patch, including layout test updates
mitz
Comment 2 2007-01-26 04:20:17 PST
Comment on attachment 12678 [details] patch, including layout test updates I think that as an enum type, property IDs should not use "all caps with underscores" style. It doesn't have to be part of this patch, but do you think it could change in the future? (I'm not sure what the -webkit- values would look like).
Darin Adler
Comment 3 2007-01-26 10:51:13 PST
(In reply to comment #2) > I think that as an enum type, property IDs should not use "all caps with > underscores" style. It doesn't have to be part of this patch, but do you think > it could change in the future? (I'm not sure what the -webkit- values would > look like). Yes, I had the same thought. I'd love to rename these at some point in the future. Making them identifiers instead of macros clears the way to using a style other than the SHOUTING_WORDS style.
Beth Dakin
Comment 4 2007-01-26 10:59:39 PST
Comment on attachment 12678 [details] patch, including layout test updates Looks good!
Sam Weinig
Comment 5 2007-01-26 18:32:45 PST
Landed in r19175.
Note You need to log in before you can comment on or make changes to this bug.