| Summary: | "unimplemented propertyID: 46" seen at dojotoolkit.org | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | CSS | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dev+webkit | ||||
| Priority: | P2 | ||||||
| Version: | 420+ | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| URL: | http://dojotoolkit.org/ | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 13846 | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2007-01-26 03:12:47 PST
Created attachment 12678 [details]
patch, including layout test updates
Comment on attachment 12678 [details]
patch, including layout test updates
I think that as an enum type, property IDs should not use "all caps with underscores" style. It doesn't have to be part of this patch, but do you think it could change in the future? (I'm not sure what the -webkit- values would look like).
(In reply to comment #2) > I think that as an enum type, property IDs should not use "all caps with > underscores" style. It doesn't have to be part of this patch, but do you think > it could change in the future? (I'm not sure what the -webkit- values would > look like). Yes, I had the same thought. I'd love to rename these at some point in the future. Making them identifiers instead of macros clears the way to using a style other than the SHOUTING_WORDS style. Comment on attachment 12678 [details]
patch, including layout test updates
Looks good!
|