Bug 123849

Summary: FTL should support NewObject
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Description Flags
the patch oliver: review+

Description Filip Pizlo 2013-11-05 19:12:41 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-05 19:13:36 PST
Created attachment 216109 [details]
the patch
Comment 2 WebKit Commit Bot 2013-11-05 19:15:56 PST
Attachment 216109 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1
Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:94:  JSCell_freeListNext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-11-05 20:38:25 PST
Landed in http://trac.webkit.org/changeset/158717