Bug 123749 – AX: media controls accessibility needs more work

• Component: Accessibility
• Status: RESOLVED FIXED

[James Craig]

AX: usability clean up on media controls accessibility

Bug 121990 resolved the accessibility regressions in the media controls, but some of the button roles/descriptions could be improved. For example, there is a "Display Full Screen" check box, that would be better exposed as "Exit Full Screen, button" than "Display Full Screen, checked check box". Similarly, the Mute button should switch to an "Unmute, button" rather than "Mute, checked check box." There are probably a few more items to clean up, too.

[Radar WebKit Bug Importer]

<rdar://problem/15384781>

[James Craig]

Looks like the captions popup never really worked properly either. (Not a regression, but needs fixing.)

[James Craig]

Created attachment 215982 [details]
partial patch (may need more)

[James Craig]

Now the caption popup is screen reader and keyboard accessible, assuming you can get keyboard focus into the shadow DOM (e.g. with a screen reader or with a mouse click on the Captions popup button). Arrow keys change selection, escape will close the menu, and spacebar/return/enter will select the current menu item, matching OS X HI guidelines for keyboard control of menus.

[James Craig]

(In reply to comment #4)
> …assuming you can get keyboard focus into the shadow DOM…

This is in reference to Bug 117857 - FKA: Default HTML 5 Video controls are not keyboard accessible

[Build Bot]

Comment on attachment 215982 [details]
partial patch (may need more)

Attachment 215982 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19598935

New failing tests:
media/controls-styling-strict.html
accessibility/media-element.html
media/controls-strict.html
media/audio-controls-rendering.html
media/controls-without-preload.html

[Build Bot]

Created attachment 215985 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 215982 [details]
partial patch (may need more)

Attachment 215982 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/20328818

New failing tests:
media/controls-strict.html
media/controls-styling-strict.html
media/audio-controls-rendering.html
accessibility/media-element.html
media/controls-without-preload.html
media/controls-after-reload.html

[Build Bot]

Created attachment 215989 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[James Craig]

Created attachment 216004 [details]
patch

[Jer Noble]

Comment on attachment 216004 [details]
patch

r=me. It'd be nice if the change from aria-checked -> aria-label for muteButton, fullscreenButton, and captionButton was mentioned in the ChangeLog.

[James Craig]

(In reply to comment #11)
> (From update of attachment 216004 [details])
> r=me. It'd be nice if the change from aria-checked -> aria-label for muteButton, fullscreenButton, and captionButton was mentioned in the ChangeLog.

That was this comment:
"Updated some of the control labels/roles to improve accessibilty."

…but I'll update to provide more specifics.

[James Craig]

Created attachment 216105 [details]
patch with review feedback

[WebKit Commit Bot]

Comment on attachment 216105 [details]
patch with review feedback

Clearing flags on attachment: 216105

Committed r158713: <http://trac.webkit.org/changeset/158713>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.