Bug 123749

Summary: AX: media controls accessibility needs more work
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jdiggs, jer.noble, mario, mikereiser08, rniwa, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 121990    
Bug Blocks: 127260, 117857, 120956    
Attachments:
Description Flags
partial patch (may need more)
jcraig: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
none
patch
jer.noble: review+
patch with review feedback none

Description James Craig 2013-11-04 11:09:59 PST
AX: usability clean up on media controls accessibility

Bug 121990 resolved the accessibility regressions in the media controls, but some of the button roles/descriptions could be improved. For example, there is a "Display Full Screen" check box, that would be better exposed as "Exit Full Screen, button" than "Display Full Screen, checked check box". Similarly, the Mute button should switch to an "Unmute, button" rather than "Mute, checked check box." There are probably a few more items to clean up, too.
Comment 1 Radar WebKit Bug Importer 2013-11-04 11:10:26 PST
<rdar://problem/15384781>
Comment 2 James Craig 2013-11-04 13:45:56 PST
Looks like the captions popup never really worked properly either. (Not a regression, but needs fixing.)
Comment 3 James Craig 2013-11-04 18:51:59 PST
Created attachment 215982 [details]
partial patch (may need more)
Comment 4 James Craig 2013-11-04 18:58:54 PST
Now the caption popup is screen reader and keyboard accessible, assuming you can get keyboard focus into the shadow DOM (e.g. with a screen reader or with a mouse click on the Captions popup button). Arrow keys change selection, escape will close the menu, and spacebar/return/enter will select the current menu item, matching OS X HI guidelines for keyboard control of menus.
Comment 5 James Craig 2013-11-04 19:02:05 PST
(In reply to comment #4)
> …assuming you can get keyboard focus into the shadow DOM…

This is in reference to Bug 117857 - FKA: Default HTML 5 Video controls are not keyboard accessible
Comment 6 Build Bot 2013-11-04 19:40:56 PST
Comment on attachment 215982 [details]
partial patch (may need more)

Attachment 215982 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19598935

New failing tests:
media/controls-styling-strict.html
accessibility/media-element.html
media/controls-strict.html
media/audio-controls-rendering.html
media/controls-without-preload.html
Comment 7 Build Bot 2013-11-04 19:40:58 PST
Created attachment 215985 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2013-11-04 20:22:35 PST
Comment on attachment 215982 [details]
partial patch (may need more)

Attachment 215982 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/20328818

New failing tests:
media/controls-strict.html
media/controls-styling-strict.html
media/audio-controls-rendering.html
accessibility/media-element.html
media/controls-without-preload.html
media/controls-after-reload.html
Comment 9 Build Bot 2013-11-04 20:22:36 PST
Created attachment 215989 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 James Craig 2013-11-04 22:17:30 PST
Created attachment 216004 [details]
patch
Comment 11 Jer Noble 2013-11-05 17:32:36 PST
Comment on attachment 216004 [details]
patch

r=me. It'd be nice if the change from aria-checked -> aria-label for muteButton, fullscreenButton, and captionButton was mentioned in the ChangeLog.
Comment 12 James Craig 2013-11-05 17:42:15 PST
(In reply to comment #11)
> (From update of attachment 216004 [details])
> r=me. It'd be nice if the change from aria-checked -> aria-label for muteButton, fullscreenButton, and captionButton was mentioned in the ChangeLog.

That was this comment:
"Updated some of the control labels/roles to improve accessibilty."

…but I'll update to provide more specifics.
Comment 13 James Craig 2013-11-05 17:55:54 PST
Created attachment 216105 [details]
patch with review feedback
Comment 14 WebKit Commit Bot 2013-11-05 19:48:55 PST
Comment on attachment 216105 [details]
patch with review feedback

Clearing flags on attachment: 216105

Committed r158713: <http://trac.webkit.org/changeset/158713>
Comment 15 WebKit Commit Bot 2013-11-05 19:48:58 PST
All reviewed patches have been landed.  Closing bug.