Summary: | LLVM assertion failures should funnel into WTF's crash handling | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, cmarcelo, commit-queue, ggaren, mario, mark.lam, mhahnenberg, mrowe, nrotem, oliver, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 112840 | ||||||
Attachments: |
|
Description
Filip Pizlo
2013-11-02 12:19:23 PDT
Created attachment 215826 [details]
the patch
Attachment 215826 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llvm/InitializeLLVM.cpp', u'Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp', u'Source/JavaScriptCore/llvm/library/LLVMExports.cpp', u'Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp', u'Source/JavaScriptCore/llvm/library/LLVMTrapCallback.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h', u'Tools/ChangeLog', u'Tools/Scripts/configure-llvm']" exit_code: 1
Source/WTF/wtf/Assertions.h:41: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 215826 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/158509 |