Bug 123422

Summary:

Remote Layer Tree: Support tiled drawing and use it for the main frame

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

123418

Bug Blocks:

Attachments:

Description	Flags
patch	none
patch	simon.fraser: review+

Tim Horton

Reported 2013-10-28 14:32:55 PDT

And then we'll finally have page contents painting!

Attachments
patch (33.74 KB, patch) 2013-10-29 13:17 PDT, Tim Horton	no flags	Details Formatted Diff Diff
patch (33.48 KB, patch) 2013-10-29 13:44 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-10-29 13:17:34 PDT

Created attachment 215413 [details] patch

Tim Horton

Comment 2 2013-10-29 13:18:20 PDT

Comment on attachment 215413 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=215413&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:153 > + // This is unfortunate. I really want a nice way at the PlatformCALayer level to override things but fall back on the -Remote or -Mac or -Win specific behavior (so we can get rid of our CALayer subclasses and make painting more straightforward). I will get rid of this comment, didn't mean to include it (and basically moved it into the ChangeLog anyway).

WebKit Commit Bot

Comment 3 2013-10-29 13:20:01 PDT

Attachment 215413 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h']" exit_code: 1 Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:41: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 4 2013-10-29 13:44:23 PDT

Created attachment 215416 [details] patch

Simon Fraser (smfr)

Comment 5 2013-10-29 13:52:52 PDT

Comment on attachment 215416 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=215416&action=review > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:52 > + > + Extra line.

Tim Horton

Comment 6 2013-10-29 14:03:41 PDT

http://trac.webkit.org/changeset/158223

Tim Horton

Comment 7 2013-10-29 14:24:48 PDT

and follow up in http://trac.webkit.org/changeset/158224

Note You need to log in before you can comment on or make changes to this bug.