Bug 123418

Summary: Make TileController create the appropriate PlatformCALayer subclasses
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, eric.carlson, glenn, jer.noble, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 123422    
Attachments:
Description Flags
patch
none
patch simon.fraser: review+

Description Tim Horton 2013-10-28 13:55:11 PDT
Right now it always makes PlatformCALayerMac, but it should instead ask its owning GraphicsLayer to make an appropriate PlatformCALayer, be it Mac, Win, or Remote.
Comment 1 Tim Horton 2013-10-28 14:07:21 PDT
Created attachment 215332 [details]
patch

Not sure if I should move LayerType enum to a different file to get rid of this nasty casting, or if there's a better solution.
Comment 2 Tim Horton 2013-10-28 17:59:08 PDT
Created attachment 215355 [details]
patch
Comment 3 Simon Fraser (smfr) 2013-10-28 18:24:04 PDT
Comment on attachment 215355 [details]
patch

Let's call it "compatible".
Comment 4 Tim Horton 2013-10-28 19:44:00 PDT
http://trac.webkit.org/changeset/158160