Bug 123139

Summary: Remote Layer Tree: Support hardware accelerated filters
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dino, eflews.bot, gyuyoung.kim, rego+ews, simon.fraser, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 123330    
Bug Blocks:    
Attachments:
Description Flags
patch andersca: review+, eflews.bot: commit-queue-

Tim Horton
Reported 2013-10-21 23:29:13 PDT
I took the approach of serializing FilterOperation and FilterOperations and using existing PlatformCAFiltersMac code to apply them on the UI process side. I haven't added custom filter support yet, that might be slightly more tricky.
Attachments
patch (27.18 KB, patch)
2013-10-22 00:07 PDT, Tim Horton
andersca: review+
eflews.bot: commit-queue-
Tim Horton
Comment 1 2013-10-22 00:07:10 PDT
Tim Horton
Comment 2 2013-10-22 00:07:46 PDT
(In reply to comment #0) > I took the approach of serializing FilterOperation and FilterOperations and using existing PlatformCAFiltersMac code to apply them on the UI process side. > > I haven't added custom filter support yet, that might be slightly more tricky. Actually it looks like we don't have accelerated custom filters so we don't need this.
EFL EWS Bot
Comment 3 2013-10-22 00:12:59 PDT
Anders Carlsson
Comment 4 2013-10-22 07:06:51 PDT
Comment on attachment 214823 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=214823&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1183 > +static void encodeFilterOperation(ArgumentEncoder& encoder, FilterOperation* filter) I think FilterOperation should be a const reference. > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1318 > + filters.operations().append(filter); Can use std::move(filter) here to avoid ref churn.
Tim Horton
Comment 5 2013-10-22 12:24:01 PDT
Note You need to log in before you can comment on or make changes to this bug.