Bug 123066

Summary: Mac DumpRenderTree builds without NDEBUG even in release mode
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86914    
Attachments:
Description Flags
proposed fix
none
proposed fix none

Alexey Proskuryakov
Reported 2013-10-19 12:45:31 PDT
Crazy. I noticed this when I tried to use RefPtr with an ArrayBufferView passed from a test - since that was created in NDEBUG code, the object lacked these variables, and assertions were off: #if CHECK_REF_COUNTED_LIFECYCLE bool m_deletionHasBegun; bool m_adoptionIsRequired; ThreadRestrictionVerifier m_verifier; #endif
Attachments
proposed fix (1.87 KB, patch)
2013-10-19 12:53 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed fix (2.47 KB, patch)
2013-10-19 14:50 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-19 12:53:25 PDT
Created attachment 214661 [details] proposed fix
Alexey Proskuryakov
Comment 2 2013-10-19 14:50:30 PDT
Created attachment 214674 [details] proposed fix Dan found that this was incorrect - it fixed release builds, but added NDEBUG to debugs ones too. Changed to more closely follow what other projects do.
WebKit Commit Bot
Comment 3 2013-10-19 16:16:59 PDT
Comment on attachment 214674 [details] proposed fix Clearing flags on attachment: 214674 Committed r157686: <http://trac.webkit.org/changeset/157686>
WebKit Commit Bot
Comment 4 2013-10-19 16:17:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.