Summary: | [CSSRegions] Move regions auto-size code into RenderNamedFlowFragment | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||||
Component: | CSS | Assignee: | Andrei Bucur <abucur> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abucur, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mibalan, WebkitBugTracker | ||||||||
Priority: | P2 | Keywords: | AdobeTracked | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 57312 | ||||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2013-10-17 05:28:26 PDT
Created attachment 220633 [details]
Patch
(In reply to comment #1) > Created an attachment (id=220633) [details] > Patch Would not have been easier to make *hasAutoLogicalHeight* a virtual which returns false in RenderRegion and do the check in RenderNamedFlowFragment? The static implementation in RenderFlowThread calls isRenderNamedFlowFragment() which is already a virtual method. Created attachment 220704 [details]
Patch
Comment on attachment 220704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220704&action=review r=me, please take a look at the comments before landing. > Source/WebCore/rendering/RenderNamedFlowFragment.cpp:159 > + ASSERT(newLogicalHeight < LayoutUnit::max() / 2); I would use RenderFlowThread::maxLogicalHeight() instead of LayoutUnit::max() / 2. > Source/WebCore/rendering/RenderTreeAsText.cpp:671 > + if (isRenderNamedFlowFragment && toRenderNamedFlowFragment(renderRegion)->hasAutoLogicalHeight()) Since hasAutoLogicalHeight always returns false for RenderRegion, you can still use the previous condition. Created attachment 220709 [details]
Patch
Comment on attachment 220709 [details] Patch Clearing flags on attachment: 220709 Committed r161553: <http://trac.webkit.org/changeset/161553> All reviewed patches have been landed. Closing bug. |