Bug 122555

Summary: [arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, msaboff, ossy, rgabor, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). none

Description Julien Brianceau 2013-10-09 09:31:10 PDT
I think that the src and dest registers in moveDouble() call are inverted when CPU(ARM) and CPU(ARM_HARDFP).
Comment 1 Julien Brianceau 2013-10-09 09:33:16 PDT
Created attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).
Comment 2 Julien Brianceau 2013-10-09 09:35:36 PDT
Comment on attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).

Please note that I found this by reading the code and I don't have an ARM environment to validate this patch.
Comment 3 WebKit Commit Bot 2013-10-09 10:01:07 PDT
Comment on attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).

Clearing flags on attachment: 213784

Committed r157173: <http://trac.webkit.org/changeset/157173>
Comment 4 WebKit Commit Bot 2013-10-09 10:01:10 PDT
All reviewed patches have been landed.  Closing bug.