Bug 122265

Summary:

[CSS Regions] Follow-up code style change after bug #121828 All regions have layers

Product:

WebKit

Reporter:

Mihai Maerean <mmaerean>

Component:

WebCore Misc.

Assignee:

Mihai Maerean <mmaerean>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57312

Attachments:

Description	Flags
patch	none

Description Mihai Maerean 2013-10-03 05:39:37 PDT

Implement the changes requested in review at bug #121828 All regions have layers https://bugs.webkit.org/show_bug.cgi?id=121828#c14

Comment 1 Mihai Maerean 2013-10-03 06:33:44 PDT

Created attachment 213243 [details]
patch

Comment 2 Darin Adler 2013-10-03 12:24:31 PDT

Comment on attachment 213243 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213243&action=review

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:417
> +    // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS
> +    // specification states that the column boxes do not establish new Stacking Contexts.

Missing comma here after the word "but". I’ll set commit-queue+ anyway, because we should not hold this all up just for a comma.

Comment 3 WebKit Commit Bot 2013-10-03 12:51:50 PDT

Comment on attachment 213243 [details]
patch

Clearing flags on attachment: 213243

Committed r156850: <http://trac.webkit.org/changeset/156850>

Comment 4 WebKit Commit Bot 2013-10-03 12:51:52 PDT

All reviewed patches have been landed.  Closing bug.