Bug 122265 - [CSS Regions] Follow-up code style change after bug #121828 All regions have layers
Summary: [CSS Regions] Follow-up code style change after bug #121828 All regions have ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
Depends on:
Blocks: 57312
  Show dependency treegraph
Reported: 2013-10-03 05:39 PDT by Mihai Maerean
Modified: 2013-10-03 12:51 PDT (History)
6 users (show)

See Also:

patch (4.17 KB, patch)
2013-10-03 06:33 PDT, Mihai Maerean
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Maerean 2013-10-03 05:39:37 PDT
Implement the changes requested in review at bug #121828 All regions have layers https://bugs.webkit.org/show_bug.cgi?id=121828#c14
Comment 1 Mihai Maerean 2013-10-03 06:33:44 PDT
Created attachment 213243 [details]
Comment 2 Darin Adler 2013-10-03 12:24:31 PDT
Comment on attachment 213243 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=213243&action=review

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:417
> +    // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS
> +    // specification states that the column boxes do not establish new Stacking Contexts.

Missing comma here after the word "but". I’ll set commit-queue+ anyway, because we should not hold this all up just for a comma.
Comment 3 WebKit Commit Bot 2013-10-03 12:51:50 PDT
Comment on attachment 213243 [details]

Clearing flags on attachment: 213243

Committed r156850: <http://trac.webkit.org/changeset/156850>
Comment 4 WebKit Commit Bot 2013-10-03 12:51:52 PDT
All reviewed patches have been landed.  Closing bug.