Bug 122197

Summary: [CSS Shapes] Shape Outside should relayout when set dynamically
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114546, 122340    
Attachments:
Description Flags
Test case
none
Patch
none
Updated patch
achicu: review+, achicu: commit-queue-
Incorporating feedback none

Bear Travis
Reported 2013-10-01 17:34:35 PDT
Shape outside on a float should cause relayout when added, modified, or removed dynamically. Test case has a shape-outside dynamically added after a 5 second delay. Relayout does not currently occur.
Attachments
Test case (598 bytes, text/html)
2013-10-01 17:35 PDT, Bear Travis 		no flags
Details
Patch (8.14 KB, patch)
2013-10-03 14:30 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Updated patch (13.24 KB, patch)
2013-10-03 15:03 PDT, Bear Travis 		achicu: review+
achicu: commit-queue-
DetailsFormatted DiffDiff
Incorporating feedback (12.83 KB, patch)
2013-10-04 12:02 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-10-01 17:35:07 PDT
Created attachment 213135 [details] Test case
Bear Travis
Comment 2 2013-10-03 14:30:02 PDT
Created attachment 213298 [details] Patch
Bear Travis
Comment 3 2013-10-03 15:03:19 PDT
Created attachment 213301 [details] Updated patch Adding overhang tests and cleaning up existing tests
Alexandru Chiculita
Comment 4 2013-10-04 11:29:10 PDT
Comment on attachment 213301 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=213301&action=review This is unrelated to your current change, but I think we need to consolidate removeFloatingOrPositionedChildFromBlockLists to avoid calling it twice in the same style change. Currently there are already two places that could call removeFloatingOrPositionedChildFromBlockLists in the same style change. Can you add a bug for it please? r=me > LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:9 > + if (document.body) > + document.body.offsetTop; > + else if (document.documentElement) > + document.documentElement.offsetTop; nit: I think that onload will always have a document.body. > LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:14 > + el.setAttribute('class', 'shape rectangle50'); nit: you can use el.className = "";
Bear Travis
Comment 5 2013-10-04 12:02:44 PDT
Created attachment 213385 [details] Incorporating feedback
WebKit Commit Bot
Comment 6 2013-10-04 12:29:37 PDT
Comment on attachment 213385 [details] Incorporating feedback Clearing flags on attachment: 213385 Committed r156905: <http://trac.webkit.org/changeset/156905>
WebKit Commit Bot
Comment 7 2013-10-04 12:29:39 PDT
All reviewed patches have been landed. Closing bug.
Bear Travis
Comment 8 2014-01-14 13:05:04 PST
*** Bug 114527 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.