| Summary: | Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 122024 | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2013-10-01 14:16:25 PDT
*** Bug 108019 has been marked as a duplicate of this bug. *** Created attachment 213119 [details]
work in progress
Created attachment 213121 [details]
the patch
Comment on attachment 213121 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=213121&action=review r=me > Source/JavaScriptCore/dfg/DFGVariableEvent.h:234 > + return static_cast<VirtualRegister>(m_representation.virtualReg); You can just use constructor syntax here: VirtualRegister(m_representation.virtualReg). > Source/JavaScriptCore/dfg/DFGVariableEvent.h:240 > + return static_cast<VirtualRegister>(m_representation.virtualReg); Ditto. > Source/JavaScriptCore/dfg/DFGVariableEvent.h:246 > + return static_cast<VirtualRegister>(m_which.virtualReg); You can just use constructor syntax here: VirtualRegister(m_which.virtualReg). Comment on attachment 213121 [details] the patch Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2902186 (In reply to comment #5) > (From update of attachment 213121 [details]) > Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/2902186 Looks like an ICE. Not my problem. Landed in http://trac.webkit.org/changeset/156747 |