Bug 122172

Summary: Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121859    
Attachments:
Description Flags
preliminary patch
buildbot: commit-queue-
fix windows andersca: review+

Tim Horton
Reported 2013-10-01 12:54:46 PDT
So that when we turn on tiled drawing for mac-wk2 on all tests, we don't need separate results for every test that deals with GraphicsLayer tree dumps. This *will* require rebaselining the current tiled-drawing tests, though.
Attachments
preliminary patch (30.40 KB, patch)
2013-10-01 13:11 PDT, Tim Horton 		buildbot: commit-queue-
DetailsFormatted DiffDiff
fix windows (30.58 KB, patch)
2013-10-01 14:07 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-01 13:11:36 PDT
Created attachment 213115 [details] preliminary patch
Build Bot
Comment 2 2013-10-01 13:50:21 PDT
Comment on attachment 213115 [details] preliminary patch Attachment 213115 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/2908159
Tim Horton
Comment 3 2013-10-01 14:07:43 PDT
Created attachment 213118 [details] fix windows
Anders Carlsson
Comment 4 2013-10-01 16:30:48 PDT
Comment on attachment 213118 [details] fix windows View in context: https://bugs.webkit.org/attachment.cgi?id=213118&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2095 > + return (m_isMainFrameRenderViewLayer && layer && layer == m_childContainmentLayer.get()); No need for the parentheses here.
Tim Horton
Comment 5 2013-10-01 16:41:43 PDT
http://trac.webkit.org/changeset/156749
Note You need to log in before you can comment on or make changes to this bug.