Bug 122139

Summary: Build fix for EFL, Qt, Gtk port after r156688
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit Misc.Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, commit-queue, gustavo, lucas.de.marchi, luiz, mrobinson, noam, webkit-ews, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122136    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2013-09-30 22:32:04 PDT
While removing Some OwnPtr and PassOwnPtr, some port specific methods are not renamed.
Attachments
Patch (13.22 KB, patch)
2013-09-30 22:33 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (13.33 KB, patch)
2013-09-30 22:53 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (16.24 KB, patch)
2013-09-30 23:13 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (17.17 KB, patch)
2013-09-30 23:26 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-09-30 22:33:51 PDT
Created attachment 213056 [details] Patch
Anders Carlsson
Comment 2 2013-09-30 22:35:08 PDT
Comment on attachment 213056 [details] Patch Thanks for fixing!
Early Warning System Bot
Comment 3 2013-09-30 22:48:17 PDT
Comment on attachment 213056 [details] Patch Attachment 213056 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2920003
Ryuan Choi
Comment 4 2013-09-30 22:53:50 PDT
Created attachment 213058 [details] Patch
Ryuan Choi
Comment 5 2013-09-30 23:13:22 PDT
Created attachment 213059 [details] Patch
WebKit Commit Bot
Comment 6 2013-09-30 23:14:56 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Ryuan Choi
Comment 7 2013-09-30 23:26:03 PDT
Created attachment 213060 [details] Patch
Ryuan Choi
Comment 8 2013-09-30 23:36:37 PDT
Committed r156700: <http://trac.webkit.org/changeset/156700>
Ryuan Choi
Comment 9 2013-09-30 23:38:41 PDT
Comment on attachment 213060 [details] Patch Clearing flags. I fixed build break on qt, gtk-wk2, efl-wk2. (efl bot looks insane, now) Hopefully, qt-wk2 will be also fixed.
Note You need to log in before you can comment on or make changes to this bug.