Bug 122026

Summary:

Don't retry failures on Apple MountainLion Release WK1 tester

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ggaren, lforschler

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

122023

Bug Blocks:

Attachments:

Description	Flags
proposed patch	mrowe: review+

Alexey Proskuryakov

Reported 2013-09-27 11:25:24 PDT

There are no flaky tests on this bot now, and if we introduce any, we should be told about that in RED.

Attachments
proposed patch (1.53 KB, patch) 2013-09-27 11:29 PDT, Alexey Proskuryakov	mrowe: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-09-27 11:29:35 PDT

Created attachment 212827 [details] proposed patch There is a potential downside to this change - run-webkit-tests forces pixel testing when retrying, so it provides pixel results for tests that failed both times. But forcing pixel tests changes a lot anyway, so I'm not sure if those pixel results were more useful or misleading.

Mark Rowe (bdash)

Comment 2 2013-09-27 13:29:56 PDT

Comment on attachment 212827 [details] proposed patch Looks fine except for the obvious typo: --no-retry-faiures. Please fix that before landing.

Alexey Proskuryakov

Comment 3 2013-09-27 13:47:29 PDT

Committed <http://trac.webkit.org/r156571>.

Note You need to log in before you can comment on or make changes to this bug.