Bug 121856

Summary:

Make explicit our use of sRGB as the 'untagged' color space

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Layout and Rendering

Assignee:

Tim Horton <thorton>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

bdakin, buildbot, commit-queue, dino, jonlee, mitz, rniwa, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

121857, 121859

Bug Blocks:

9567, 5972

Attachments:

Description	Flags
preliminary patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none

Tim Horton

Reported 2013-09-24 13:10:36 PDT

On Mountain Lion, CG's default interpretation of DeviceRGB is 'sRGB', whereas CG with 'drawsAsynchronously' on interprets DeviceRGB to be "untagged", flowing unmatched into the context it's painted into. To make everything match up and to make our behavior consistent on all platforms, we should just use sRGB instead of device everywhere, explicitly, matching the CSS and SVG specs. We need to do some performance testing, and investigate the situation with plugins.

Attachments
preliminary patch (152.34 KB, patch) 2014-09-11 16:34 PDT, Tim Horton	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (546.90 KB, application/zip) 2014-09-11 18:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (538.27 KB, application/zip) 2014-09-11 19:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (559.03 KB, application/zip) 2014-09-11 19:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (616.37 KB, application/zip) 2014-09-11 20:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (616.08 KB, application/zip) 2014-09-11 21:23 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-09-24 13:11:05 PDT

<rdar://problem/15069231>

Tim Horton

Comment 2 2014-09-11 16:33:10 PDT

On Mavericks, both interpret DeviceRGB as sRGB.

Tim Horton

Comment 3 2014-09-11 16:34:22 PDT

Created attachment 237996 [details] preliminary patch

WebKit Commit Bot

Comment 4 2014-09-11 16:37:12 PDT

Attachment 237996 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:505: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:565: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 113 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2014-09-11 18:09:40 PDT

Comment on attachment 237996 [details] preliminary patch Attachment 237996 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6711950989852672 New failing tests: svg/css/getComputedStyle-basic.xhtml accessibility/content-editable-as-textarea.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 6 2014-09-11 18:09:43 PDT

Created attachment 238003 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-09-11 19:02:35 PDT

Comment on attachment 237996 [details] preliminary patch Attachment 237996 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5878020812308480 New failing tests: svg/css/getComputedStyle-basic.xhtml accessibility/content-editable-as-textarea.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 8 2014-09-11 19:02:40 PDT

Created attachment 238005 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-09-11 19:39:05 PDT

Comment on attachment 237996 [details] preliminary patch Attachment 237996 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4542362218921984 New failing tests: svg/css/getComputedStyle-basic.xhtml accessibility/content-editable-as-textarea.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 10 2014-09-11 19:39:09 PDT

Created attachment 238009 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2014-09-11 20:23:05 PDT

Comment on attachment 237996 [details] preliminary patch Attachment 237996 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5785467488305152 New failing tests: svg/css/getComputedStyle-basic.xhtml accessibility/content-editable-as-textarea.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 12 2014-09-11 20:23:08 PDT

Created attachment 238011 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 13 2014-09-11 21:23:01 PDT

Comment on attachment 237996 [details] preliminary patch Attachment 237996 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6359109762809856 New failing tests: svg/css/getComputedStyle-basic.xhtml accessibility/content-editable-as-textarea.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 14 2014-09-11 21:23:05 PDT

Created attachment 238014 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Note You need to log in before you can comment on or make changes to this bug.