Bug 121849

Summary: Implement symbol name hashing for WebGL shaders
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kondapallykalyan, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126832, 132430    
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Dean Jackson
Reported 2013-09-24 11:28:49 PDT
ANGLE provides the feature to do symbol name translation for everything. This is handy if lower-level GL drivers do not like compiling shaders that redefine built-in symbol names (e.g. "sin"). This causes us to fail the Khronos test conformance/glsl/misc/shader-with-non-reserved-words.html on some hardware. Turn on the name mapping. I have some complaints with the technique that ANGLE provides, but a combination of our 32bit hash plus incrementing number should be fine. https://code.google.com/p/angleproject/issues/detail?id=474 <rdar://problem/15036575>
Attachments
Patch (8.52 KB, patch)
2013-09-24 11:37 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2013-09-24 12:30 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2013-09-24 12:37 PDT, Dean Jackson 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-09-24 11:37:44 PDT
Created attachment 212486 [details] Patch
Dean Jackson
Comment 2 2013-09-24 12:30:49 PDT
Created attachment 212489 [details] Patch
Dean Jackson
Comment 3 2013-09-24 12:37:08 PDT
Created attachment 212490 [details] Patch
Dean Jackson
Comment 4 2013-09-24 12:43:32 PDT
Committed r156352: <http://trac.webkit.org/changeset/156352>
Note You need to log in before you can comment on or make changes to this bug.