Bug 12175

Summary: port break_lines.cpp to be platform independent
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: mitz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch, including change log -- passes all layout tests hyatt: review+

Darin Adler
Reported 2007-01-08 22:03:55 PST
Hyatt asked me to port break_lines.cpp to "use ICU", but it can be ported to use TextBreakIterator.h and hence be more-or-less platform independent.
Attachments
patch, including change log -- passes all layout tests (11.31 KB, patch)
2007-01-08 22:07 PST, Darin Adler 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-01-08 22:07:00 PST
Created attachment 12324 [details] patch, including change log -- passes all layout tests
Dave Hyatt
Comment 2 2007-01-08 22:33:05 PST
Comment on attachment 12324 [details] patch, including change log -- passes all layout tests r=me. Run tests!
mitz
Comment 3 2007-01-08 23:04:45 PST
Be sure to test Thai word breaks! See <http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/test/thaitest/> for possible test data.
Darin Adler
Comment 4 2007-01-09 05:43:20 PST
*** This bug has been marked as a duplicate of 4628 ***
Note You need to log in before you can comment on or make changes to this bug.