Bug 121456

Summary: Move the widow functions/members out of RenderBlock and into RenderBlockFlow.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84924    
Attachments:
Description Flags
Patch dino: review+

Dave Hyatt
Reported 2013-09-16 15:08:00 PDT
Move the widow functions/members out of RenderBlock and into RenderBlockFlow.
Attachments
Patch (29.37 KB, patch)
2013-09-16 15:08 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2013-09-16 15:08:52 PDT
Created attachment 211835 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-16 15:11:28 PDT
Attachment 211835 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderObject.h']" exit_code: 1 Source/WebCore/rendering/RenderBlockFlow.cpp:1348: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:1349: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:1354: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:1358: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2013-09-17 09:40:45 PDT
Landed in r155964.
Note You need to log in before you can comment on or make changes to this bug.