Bug 121391

Summary: Clean up WebSocket code and prevent it from dropping messages
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, graouts, gustavo, joepeck, rtakacs, seokju, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121383    
Attachments:
Description Flags
Patch
none
Patch joepeck: review+

Timothy Hatcher
Reported 2013-09-15 08:57:30 PDT
Clean up WebSocket code and prevent it from dropping messages
Attachments
Patch (5.28 KB, patch)
2013-09-15 08:59 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (5.61 KB, patch)
2013-09-15 09:05 PDT, Timothy Hatcher 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-09-15 08:59:43 PDT
Created attachment 211710 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-09-15 09:00:35 PDT
<rdar://problem/14995089>
Timothy Hatcher
Comment 3 2013-09-15 09:00:49 PDT
Roland, can you test this for me? It should fix the issue you emailed about.
Radar WebKit Bug Importer
Comment 4 2013-09-15 09:01:17 PDT
<rdar://problem/14995091>
Timothy Hatcher
Comment 5 2013-09-15 09:05:14 PDT
Created attachment 211711 [details] Patch
Roland Takacs
Comment 6 2013-09-15 15:29:57 PDT
It seems the appearance and the functionality are good, but there are some random WebProcess crashes. Tomorrow I will determine what causes them.
Timothy Hatcher
Comment 7 2013-09-16 10:04:48 PDT
*** Bug 121315 has been marked as a duplicate of this bug. ***
Timothy Hatcher
Comment 8 2013-09-16 10:10:31 PDT
The crashes are likely not related.
Joseph Pecoraro
Comment 9 2013-09-16 11:02:49 PDT
Comment on attachment 211711 [details] Patch r=me. It sounds like Roland Takacs tested it and it worked for him as well. But I'll let you cq it.
Joseph Pecoraro
Comment 10 2013-09-16 11:03:08 PDT
Comment on attachment 211711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211711&action=review > Source/WebInspectorUI/ChangeLog:13 > + if the socket ins't ready yet. Call _sendPendingMessagesToBackendIfNeeded. Typo: ins't
Roland Takacs
Comment 11 2013-09-16 14:05:11 PDT
(In reply to comment #8) > The crashes are likely not related. Yes, as I checked the crash happens at ImageBufferCairo.cpp.
Timothy Hatcher
Comment 12 2013-09-17 10:03:51 PDT
http://trac.webkit.org/changeset/155966
Note You need to log in before you can comment on or make changes to this bug.