Bug 121383

Summary: [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121391    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2013-09-15 04:35:19 PDT
It started to fail (timeout) after the move to the new web inspector (I think)
Attachments
Patch (2.97 KB, patch)
2013-09-15 19:19 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-09-15 19:17:14 PDT
The timeout is caused by 121315, but I neglected this test and it needs fixage too, because one of its assumptions is no longer true. Patch incoming.
Gustavo Noronha (kov)
Comment 2 2013-09-15 19:19:12 PDT
Created attachment 211734 [details] Patch
WebKit Commit Bot
Comment 3 2013-09-15 19:21:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 4 2013-09-17 12:26:28 PDT
Comment on attachment 211734 [details] Patch Clearing flags on attachment: 211734 Committed r155985: <http://trac.webkit.org/changeset/155985>
Gustavo Noronha (kov)
Comment 5 2013-09-17 12:26:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.