Bug 121323

Summary: Make FloatingObjects own it's FloatingObject instances
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, phiw2, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Bem Jones-Bey
Reported 2013-09-13 14:36:42 PDT
Make FloatingObjects own it's FloatingObject instances
Attachments
Patch (19.80 KB, patch)
2013-09-13 16:10 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (19.79 KB, patch)
2013-09-16 14:28 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (19.80 KB, patch)
2013-09-16 14:30 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-09-13 16:10:50 PDT
Created attachment 211598 [details] Patch
Alexandru Chiculita
Comment 2 2013-09-13 16:46:48 PDT
Comment on attachment 211598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211598&action=review Looks good. Thanks! > Source/WebCore/rendering/FloatingObjects.cpp:174 > +void FloatingObjects::exportToFloatInfoMap(RendererToFloatInfoMap& map) nit: The function name is confusing as it doesn't say it is releasing the ownership of its own content. > Source/WebCore/rendering/RenderBlock.cpp:3307 > + m_floatingObjects->add(newObj.release()); nit: Might be usefull to make "add" return a pointer to the floating object to avoid the manual store on the stack.
Bem Jones-Bey
Comment 3 2013-09-16 14:28:28 PDT
Created attachment 211831 [details] Patch rename export method and make FloatingObjects::add have a return value per review feedback.
Bem Jones-Bey
Comment 4 2013-09-16 14:30:10 PDT
Created attachment 211832 [details] Patch Add reviewer name
WebKit Commit Bot
Comment 5 2013-09-16 15:00:37 PDT
Comment on attachment 211832 [details] Patch Clearing flags on attachment: 211832 Committed r155906: <http://trac.webkit.org/changeset/155906>
WebKit Commit Bot
Comment 6 2013-09-16 15:00:39 PDT
All reviewed patches have been landed. Closing bug.
Philippe Wittenbergh
Comment 7 2013-09-17 20:10:04 PDT
Did this cause bug 121532 ?
Bem Jones-Bey
Comment 8 2013-09-18 08:40:33 PDT
(In reply to comment #7) > Did this cause bug 121532 ? It looks like it may have. I'm looking into it.
Simon Fraser (smfr)
Comment 9 2014-10-27 13:31:52 PDT
This caused bug 138100.
Note You need to log in before you can comment on or make changes to this bug.