Bug 121216

Summary: [mac] Public header WKBase.h imports a private header, WKBaseMac.h
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121215    
Attachments:
Description Flags
Possible fix
none
Move public parts of WKBase.h into new public headers, make WKBase.h private darin: review+

Description mitz 2013-09-11 23:55:22 PDT
With a fix for bug 121215 in place, WebKit2 fails the include consistency check because WKBase.h is a public header, yet it include WKBaseMac.h, which is a private header.
Comment 1 mitz 2013-09-12 00:01:46 PDT
<rdar://problem/14973091>
Comment 2 mitz 2013-09-13 01:24:04 PDT
Created attachment 211519 [details]
Possible fix
Comment 3 Build Bot 2013-09-13 14:07:32 PDT
Comment on attachment 211519 [details]
Possible fix

Attachment 211519 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1817149
Comment 4 mitz 2013-09-13 14:36:30 PDT
(In reply to comment #3)
> (From update of attachment 211519 [details])
> Attachment 211519 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1817149

This is just due to a stale WKBase.h in Headers in addition to the one newly installed in PrivateHeaders.
Comment 5 mitz 2013-09-14 00:58:05 PDT
Created attachment 211632 [details]
Move public parts of WKBase.h into new public headers, make WKBase.h private
Comment 6 mitz 2013-09-14 10:06:43 PDT
Fixed in <http://trac.webkit.org/r155770>. I had to add #includes in two or three more headers before landing so that WebKit2 clients will build.