Bug 121215

Summary: [mac] Check For Framework Include Consistency build phase checks the wrong framework
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mrowe, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Bug Depends on: 121216    
Bug Blocks:    
Attachments:
Description Flags
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework mrowe: review+, buildbot: commit-queue-

mitz
Reported 2013-09-11 23:52:55 PDT
The Check For Framework Include Consistency build phase invokes check-for-webkit-framework-include-consistency, which is hard-coded to check WebKit.framework rather than the target’s build product.
Attachments
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework (2.44 KB, patch)
2013-09-12 00:00 PDT, mitz 		mrowe: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-09-12 00:00:13 PDT
Created attachment 211405 [details] Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework
mitz
Comment 2 2013-09-12 00:01:19 PDT
Note: this can’t be landed as-is until bug 121216 is fixed.
Build Bot
Comment 3 2013-09-12 00:21:53 PDT
Comment on attachment 211405 [details] Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework Attachment 211405 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1856048
Build Bot
Comment 4 2013-09-12 00:40:41 PDT
Comment on attachment 211405 [details] Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework Attachment 211405 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1843048
mitz
Comment 5 2013-09-14 14:35:12 PDT
Fixed in <http://trac.webkit.org/r155788>.
Note You need to log in before you can comment on or make changes to this bug.