Bug 121087

Summary: toFooElement() should use static_cast, not reinterpret_cast.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, cdumez, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, kling, philn, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121080    
Attachments:
Description Flags
Patch
koivisto: review+, webkit-ews: commit-queue-
Patch none

Description Andreas Kling 2013-09-10 01:39:19 PDT 
Have patch.
Comment 1 Andreas Kling 2013-09-10 01:43:14 PDT 
Created attachment 211184 [details]
Patch

Didn't actually try to build this yet. Let's see how it goes..
Comment 2 Antti Koivisto 2013-09-10 01:50:25 PDT 
Comment on attachment 211184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review

> Source/WebCore/ChangeLog:19
> +            - void toFooElement(constNode*)

missing space

> Source/WebCore/dom/Node.h:786
> +void to##NodeSubclassName(const NodeSubclassName*); \
> +void to##NodeSubclassName(const NodeSubclassName&);
> +

Anders suggested to use WTF_DELETE_FUNCTION. Does that not work?
Comment 3 Early Warning System Bot 2013-09-10 01:52:17 PDT 
Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1764025
Comment 4 Early Warning System Bot 2013-09-10 01:54:58 PDT 
Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1764027
Comment 5 Andreas Kling 2013-09-10 02:02:26 PDT 
Created attachment 211186 [details]
Patch
Comment 6 Antti Koivisto 2013-09-10 02:08:09 PDT 
Comment on attachment 211184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review

> Source/WebCore/html/HTMLAnchorElement.h:158
> +NODE_TYPE_CASTS(HTMLAnchorElement)

Since this only applies to Elements ELEMENT_TYPE_CASTS might be a better name.
Comment 7 Andreas Kling 2013-09-10 02:09:19 PDT 
(In reply to comment #2)
> (From update of attachment 211184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review
> > Source/WebCore/dom/Node.h:786
> > +void to##NodeSubclassName(const NodeSubclassName*); \
> > +void to##NodeSubclassName(const NodeSubclassName&);
> > +
> 
> Anders suggested to use WTF_DELETE_FUNCTION. Does that not work?

Apparently not. It just says "no previous definition for toHurrElement()"
Comment 8 Build Bot 2013-09-10 02:20:45 PDT 
Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1734563
Comment 9 WebKit Commit Bot 2013-09-10 02:40:06 PDT 
Comment on attachment 211186 [details]
Patch

Clearing flags on attachment: 211186

Committed r155429: <http://trac.webkit.org/changeset/155429>
Comment 10 Build Bot 2013-09-10 02:40:08 PDT 
Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1735493
Comment 11 EFL EWS Bot 2013-09-10 02:50:46 PDT 
Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1763048
Comment 12 Lucas Forschler 2019-02-06 09:02:52 PST 
Mass moving XML DOM bugs to the "DOM" Component.