Bug 121080

Summary: Generate more HTML type checks and casting
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: DOMAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, gtk-ews, kling, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121087    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2013-09-09 23:40:56 PDT
Clean-up remained functions of HTML elements to auto-generated isFooElement() and toFooElement() helpers. Besides this patch clean-up unnecessary checks which are being supported by auto-generated isFooElement().
Attachments
Patch (40.43 KB, patch)
2013-09-09 23:48 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (40.43 KB, patch)
2013-09-09 23:53 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (40.43 KB, patch)
2013-09-10 00:30 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (40.83 KB, patch)
2013-09-10 18:24 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-09-09 23:48:22 PDT
Created attachment 211174 [details] Patch
Gyuyoung Kim
Comment 2 2013-09-09 23:53:13 PDT
Created attachment 211175 [details] Patch
Gyuyoung Kim
Comment 3 2013-09-09 23:54:56 PDT
CC'ing Kling.
Early Warning System Bot
Comment 4 2013-09-10 00:05:02 PDT
Comment on attachment 211175 [details] Patch Attachment 211175 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1752009
Early Warning System Bot
Comment 5 2013-09-10 00:08:04 PDT
Comment on attachment 211175 [details] Patch Attachment 211175 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1743138
Build Bot
Comment 6 2013-09-10 00:17:44 PDT
Comment on attachment 211175 [details] Patch Attachment 211175 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1761010
Gyuyoung Kim
Comment 7 2013-09-10 00:30:09 PDT
Created attachment 211180 [details] Patch
Andreas Kling
Comment 8 2013-09-10 00:31:32 PDT
Unfortunately we need to make toFooElement() use static_cast instead of reinterpret_cast as mentioned here: https://bugs.webkit.org/show_bug.cgi?id=120676#c8
Gyuyoung Kim
Comment 9 2013-09-10 00:39:25 PDT
(In reply to comment #8) > Unfortunately we need to make toFooElement() use static_cast instead of reinterpret_cast as mentioned here: > https://bugs.webkit.org/show_bug.cgi?id=120676#c8 Kling, yes, I talked it with kent on blink. But, it looks it is not easy. I need to have time to change it. *ElementTypeHelper.h may need to include all *Element.h.
Gyuyoung Kim
Comment 10 2013-09-10 00:44:55 PDT
Comment on attachment 211180 [details] Patch No request until solving reinterpret_cast<> problem.
Andreas Kling
Comment 11 2013-09-10 01:46:10 PDT
Sure, I opened bug 121087 with a patch so we can at least have correct C++ until a better solution is found :)
kov's GTK+ EWS bot
Comment 12 2013-09-10 06:13:19 PDT
Comment on attachment 211180 [details] Patch Attachment 211180 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1735497
Gyuyoung Kim
Comment 13 2013-09-10 18:24:27 PDT
Created attachment 211272 [details] Patch
WebKit Commit Bot
Comment 14 2013-09-11 01:02:00 PDT
Comment on attachment 211272 [details] Patch Clearing flags on attachment: 211272 Committed r155507: <http://trac.webkit.org/changeset/155507>
WebKit Commit Bot
Comment 15 2013-09-11 01:02:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.