| Summary: | Remove HTMLTextFormControl::fixPlaceholderRenderer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, kling, koivisto, tkent | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 87155 | ||||||
| Bug Blocks: | 120685, 121073 | ||||||
| Attachments: |
|
||||||
Created attachment 211121 [details]
Cleanup
I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's. (In reply to comment #2) > I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's. Your patch is the right fix, and it is different from the Blink change. Comment on attachment 211121 [details]
Cleanup
ok
Committed r155408: <http://trac.webkit.org/changeset/155408> |
Observe: -void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement) -{ - // FIXME: We should change the order of DOM nodes. But it makes an assertion - // failure in editing code. That's because the assertion is bogus.