| Summary: | Move the layoutBlock method into RenderBlockFlow. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, d-r, eric, esprehn+autocc, fmalita, glenn, kondapallykalyan, leviw, pdr, philn, schenney, WebkitBugTracker, webkit-ews, xan.lopez | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 84924 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Dave Hyatt
2013-09-09 11:58:11 PDT
Created attachment 211061 [details]
Patch
Attachment 211061 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1
Source/WebCore/rendering/RenderBlockFlow.cpp:94: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:197: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:197: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:229: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:233: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:236: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:320: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:325: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:374: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:378: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 10 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 211065 [details]
Patch to pass the style queue
Attachment 211065 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1
Source/WebCore/rendering/RenderBlockFlow.cpp:371: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 211067 [details]
Patch
Created attachment 211068 [details]
Patch
Comment on attachment 211068 [details] Patch Attachment 211068 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1719954 Created attachment 211069 [details]
Patch to account for Antti's patch landing. :)
Comment on attachment 211069 [details]
Patch to account for Antti's patch landing. :)
Needs more <ruby>!
Created attachment 211072 [details]
Make release builds work by removing some inlining for now.
Fix landed in r155377. |