Bug 120972

Summary:

FTL should support typed array PutByVal

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112840

Attachments:

Description	Flags
the patch	oliver: review+

Description Filip Pizlo 2013-09-07 15:32:43 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2013-09-07 15:33:24 PDT

Created attachment 210928 [details]
the patch

Comment 2 WebKit Commit Bot 2013-09-07 15:35:25 PDT

Attachment 210928 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h']" exit_code: 1
Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2013-09-07 15:43:31 PDT

(In reply to comment #2)
> Attachment 210928 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h']" exit_code: 1
> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Fixed.

> Total errors found: 1 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Oliver Hunt 2013-09-07 19:48:25 PDT

Comment on attachment 210928 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210928&action=review

>> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219
>> +                       
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Random spaces by the looks

Comment 5 Filip Pizlo 2013-09-07 21:07:31 PDT

Landed in http://trac.webkit.org/changeset/155281