Bug 120889

Summary: MediaStream API: Update RTCDataChannel to match the specification
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, syoichi, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Carlson 2013-09-06 13:08:08 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/c3862b0a83e20fc8b1f770c7e4a886a7cceb80d2 

Just adding a bunch of attributes and deprecating one.
Comment 1 Thiago de Barros Lacerda 2013-09-14 15:50:17 PDT 
Created attachment 211670 [details]
Patch
Comment 2 Thiago de Barros Lacerda 2013-09-14 15:52:03 PDT 
Created attachment 211671 [details]
Patch
Comment 3 Eric Carlson 2013-09-14 16:13:49 PDT 
Comment on attachment 211671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review

> Source/WebCore/ChangeLog:19
> +        According to WebRTC specification, RTCDataChannel must have the following new attributes:
> +        boolean ordered
> +        unsigned short maxRetransmitTime
> +        unsigned short maxRetransmits
> +        DOMString protocol
> +        boolean negotiated
> +        unsigned short id
> +
> +        and the following one was deprecated:
> +        boolean reliable
> +
> +        No new tests needed.

Please not the blink revision this was merged from.
Comment 4 Eric Carlson 2013-09-14 16:14:13 PDT 
(In reply to comment #3)
> (From update of attachment 211671 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review
> 
> > Source/WebCore/ChangeLog:19
> > +        According to WebRTC specification, RTCDataChannel must have the following new attributes:
> > +        boolean ordered
> > +        unsigned short maxRetransmitTime
> > +        unsigned short maxRetransmits
> > +        DOMString protocol
> > +        boolean negotiated
> > +        unsigned short id
> > +
> > +        and the following one was deprecated:
> > +        boolean reliable
> > +
> > +        No new tests needed.
> 
> Please not the blink revision this was merged from.

Please *note* the revision.
Comment 5 Eric Carlson 2013-09-14 16:31:20 PDT 
Comment on attachment 211671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review

>>> Source/WebCore/ChangeLog:19
>>> +        No new tests needed.
>> 
>> Please not the blink revision this was merged from.
> 
> Please *note* the revision.

I will update RTCPeerConnection-datachannel.html with bug 121102.
Comment 6 Eric Carlson 2013-09-14 17:16:09 PDT 
I will land this.
Comment 7 Eric Carlson 2013-09-14 17:52:06 PDT 
Committed in r155792: : https://trac.webkit.org/r155792