Bug 120759

Summary: Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bfulgham, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, ossy, sam, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 120696    
Attachments:
Description Flags
Patch none

Filip Pizlo
Reported 2013-09-05 00:53:53 PDT
The issues are: - run-fast-jsc is a shell script; it needs a shell that is sufficiently compatible with Darwin /bin/sh. We should either change the script or make sure that we use the right shell on other platforms. - I'm not sure if all of the perl-foo is compatible with the perl's on other platforms, though I think I should have fixed this in http://trac.webkit.org/changeset/155101.
Attachments
Patch (3.03 KB, patch)
2013-09-05 04:24 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-09-05 01:50:47 PDT
Most if not all of the Linux builders are running Debian-based systems, meaning /bin/sh links to the dash shell which is not really Bourne-compatible. http://en.wikipedia.org/wiki/Debian_Almquist_shell /bin/bash should still be available, and the script runs fine when that's used. Is /bin/bash available on Mac OSs?
Csaba Osztrogonác
Comment 2 2013-09-05 04:18:57 PDT
I have a fix for it.
Csaba Osztrogonác
Comment 3 2013-09-05 04:24:52 PDT
Created attachment 210599 [details] Patch tested on Linux bash and dash and Darwin's /bin/sh
Csaba Osztrogonác
Comment 4 2013-09-05 04:29:30 PDT
just a note: /bin/sh on Darwin is bash too: $ /bin/sh --version GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11) Copyright (C) 2007 Free Software Foundation, Inc.
Csaba Osztrogonác
Comment 5 2013-09-05 08:11:01 PDT
Comment on attachment 210599 [details] Patch Clearing flags on attachment: 210599 Committed r155118: <http://trac.webkit.org/changeset/155118>
Csaba Osztrogonác
Comment 6 2013-09-05 08:11:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.