Summary: | Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, bfulgham, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, ossy, sam, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 120696 | ||||||
Attachments: |
|
Description
Filip Pizlo
2013-09-05 00:53:53 PDT
Most if not all of the Linux builders are running Debian-based systems, meaning /bin/sh links to the dash shell which is not really Bourne-compatible. http://en.wikipedia.org/wiki/Debian_Almquist_shell /bin/bash should still be available, and the script runs fine when that's used. Is /bin/bash available on Mac OSs? I have a fix for it. Created attachment 210599 [details]
Patch
tested on Linux bash and dash and Darwin's /bin/sh
just a note: /bin/sh on Darwin is bash too: $ /bin/sh --version GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11) Copyright (C) 2007 Free Software Foundation, Inc. Comment on attachment 210599 [details] Patch Clearing flags on attachment: 210599 Committed r155118: <http://trac.webkit.org/changeset/155118> All reviewed patches have been landed. Closing bug. |