Bug 120723

Summary: fast/js/dfg-* tests should wait for the concurrent JIT
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, ggaren, mark.lam, mhahnenberg, msaboff, oliver, ossy, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 120696    
Attachments:
Description Flags
part #1
none
part #2
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion none

Description Filip Pizlo 2013-09-04 21:44:15 PDT
This was already rubber stamped by Oliver and other people.  I'll land more of this in phases.
Comment 1 Filip Pizlo 2013-09-04 22:38:52 PDT
Created attachment 210546 [details]
part #1

It turned out big enough that it could use a glance.  The interesting part is the dfgShouldBe() function in js-test-pre and standalone-pre.
Comment 2 Geoffrey Garen 2013-09-04 23:16:12 PDT
Comment on attachment 210546 [details]
part #1

r=me
Comment 3 Filip Pizlo 2013-09-04 23:29:26 PDT
(In reply to comment #1)
> Created an attachment (id=210546) [details]
> part #1
> 
> It turned out big enough that it could use a glance.  The interesting part is the dfgShouldBe() function in js-test-pre and standalone-pre.

Landed in http://trac.webkit.org/changeset/155096
Comment 4 Filip Pizlo 2013-09-05 01:04:48 PDT
Created attachment 210586 [details]
part #2
Comment 5 Build Bot 2013-09-05 03:20:24 PDT
Comment on attachment 210586 [details]
part #2

Attachment 210586 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1693895

New failing tests:
fast/js/dfg-call-function-hit-watchpoint.html
fast/js/dfg-call-method-hit-watchpoint.html
fast/js/dfg-byte-array-put.html
Comment 6 Build Bot 2013-09-05 03:20:26 PDT
Created attachment 210596 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 7 Filip Pizlo 2013-09-05 14:27:57 PDT
(In reply to comment #4)
> Created an attachment (id=210586) [details]
> part #2

Landed in http://trac.webkit.org/changeset/155122