Bug 120684

Summary: Simplify subtree relayout scheduling a bit.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121524    
Bug Blocks:    
Attachments:
Description Flags
Patch idea.
koivisto: review+
Patch for landing... none

Andreas Kling
Reported 2013-09-04 08:36:18 PDT
Simplify subtree relayout scheduling a bit.
Attachments
Patch idea. (6.30 KB, patch)
2013-09-04 08:37 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Patch for landing... (6.34 KB, patch)
2013-09-04 09:13 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-04 08:37:00 PDT
Created attachment 210462 [details] Patch idea.
Antti Koivisto
Comment 2 2013-09-04 09:08:18 PDT
Comment on attachment 210462 [details] Patch idea. View in context: https://bugs.webkit.org/attachment.cgi?id=210462&action=review > Source/WebCore/page/FrameView.cpp:2445 > + if (m_layoutRoot == &relayoutRoot) > + return; The argument could use a better name. newLayoutRoot? > Source/WebCore/page/FrameView.cpp:2466 > + InspectorInstrumentation::didInvalidateLayout(&frame()); There is some repetition with this. I wonder if splitting this up to two functions would look nicer. The inner one would return bool if it actually did invalidate layout for example.
Andreas Kling
Comment 3 2013-09-04 09:13:40 PDT
Created attachment 210467 [details] Patch for landing...
WebKit Commit Bot
Comment 4 2013-09-04 09:40:36 PDT
Comment on attachment 210467 [details] Patch for landing... Clearing flags on attachment: 210467 Committed r155046: <http://trac.webkit.org/changeset/155046>
WebKit Commit Bot
Comment 5 2013-09-04 09:40:38 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2013-09-04 11:07:48 PDT
This change made many (maybe all?) SVG tests crash with an assertion in debug builds. See <rdar://problem/14908967> for an Apple internal bug.
Andreas Kling
Comment 7 2013-09-04 11:32:41 PDT
(In reply to comment #6) > This change made many (maybe all?) SVG tests crash with an assertion in debug builds. See <rdar://problem/14908967> for an Apple internal bug. Fix here: bug 120689
Alexey Proskuryakov
Comment 8 2013-09-17 15:48:53 PDT
More fallback from this change: bug 121524.
Note You need to log in before you can comment on or make changes to this bug.