Bug 120689 - RenderSVGResource shouldn't trigger relayout during render tree teardown.
Summary: RenderSVGResource shouldn't trigger relayout during render tree teardown.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-04 11:18 PDT by Andreas Kling
Modified: 2013-09-04 11:50 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2013-09-04 11:21 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-04 11:18:28 PDT 
<rdar://problem/14908967>

Exposed by assertions added in bug 120684.
Comment 1 Andreas Kling 2013-09-04 11:21:45 PDT 
Created attachment 210479 [details]
Patch
Comment 2 Antti Koivisto 2013-09-04 11:35:23 PDT 
Comment on attachment 210479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210479&action=review

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:198
> +    if (needsLayout && !object->documentBeingDestroyed())
>          object->setNeedsLayout(true);

Should this test be in setNeedsLayout instead?
Comment 3 Andreas Kling 2013-09-04 11:49:54 PDT 
Comment on attachment 210479 [details]
Patch

Clearing flags on attachment: 210479

Committed r155055: <http://trac.webkit.org/changeset/155055>
Comment 4 Andreas Kling 2013-09-04 11:50:00 PDT 
All reviewed patches have been landed.  Closing bug.