Bug 120600 – REGRESSION(r154909): caused many crashes on Qt WK2, EFL WK2

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Zoltan Arvai]

Many (~80) css3, animations, compositing and transitions tests crashing after the patch.

Crash log said:

css3/filters/filter-animation.html
crash log for WebProcess (pid <unknown>):
STDOUT: <empty>
STDERR: Received an invalid message "CoordinatedLayerTreeHostProxy.CommitCoordinatedGraphicsState" from the web process.

http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r154911%20%2810236%29/results.html
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/r154909%20%286068%29/results.html

[Csaba Osztrogonác]

I got same crash with EFL-MiniBrowser on index.hu after scrolling down a little bit. :-/ Reverting r154909 locally solved this crash for me.

It seems there is a seriour bug somewhere in coordinated graphics 
system revealed by r154909.

cc-ing CGFX experts too

[Zoltan Arvai]

Created attachment 210277 [details]
backtrace

Backtrace for animations/additive-transform-animations.html on Qt WK2.

[Csaba Osztrogonác]

I think I got it, I'll try the following patch immediately:

diff --git a/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp b/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
index c277460..4ed58b9 100644
--- a/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
+++ b/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
@@ -727,7 +727,7 @@ bool ArgumentCoder<GraphicsLayerAnimation>::decode(ArgumentDecoder& decoder, Gra
     if (!decoder.decode(keyframesSize))
         return false;
     for (unsigned i = 0; i < keyframesSize; ++i) {
-        float keyTime;
+        double keyTime;
         RefPtr<TimingFunction> timingFunction;
         if (!decoder.decode(keyTime))
             return false;

[Csaba Osztrogonác]

Created attachment 210279 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #4)
> Created an attachment (id=210279) [details]
> Patch

It fixed index.hu with EFL's MiniBrowser. Zoltán, could you 
check if it fixes Qt's layout test crashes too, please?

[Csaba Osztrogonác]

cc-ing WK2 owners too for review

[Zoltan Arvai]

(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=210279) [details] [details]
> > Patch
> 
> It fixed index.hu with EFL's MiniBrowser. Zoltán, could you 
> check if it fixes Qt's layout test crashes too, please?

Good catch :) Tests running fine with the patch on Qt WK2.

[WebKit Commit Bot]

Comment on attachment 210279 [details]
Patch

Clearing flags on attachment: 210279

Committed r154959: <http://trac.webkit.org/changeset/154959>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sergio Correia (qrwteyrutiyoup)]

*** Bug 120588 has been marked as a duplicate of this bug. ***